Missing message captions #7

cooljeanius · 2021-04-21T07:26:20Z

From cooljeanius/A_New_Order/6. I filled in captions for most of the messages that were missing them, but there are still a few remaining where giving them a caption would involve something a little more complicated than just copying the 1st parameter to the 3rd parameter. I tried to mark all the ones I could find with TODO comments, so they should be easy to notice.

The text was updated successfully, but these errors were encountered:

cooljeanius · 2021-08-24T13:03:36Z

After PR #17 there'll only be like 2 or 3 spots left where this will still be an issue.

cooljeanius · 2021-10-12T16:21:10Z

After ~~PR #17~~ there'll only be like 2 or 3 spots left where this will still be an issue.

OK, so that's merged now... remaining spots that I can see are:

A_New_Order/macros/ano-01_06macros.cfg

Lines 121 to 122 in 3b71676

    
           # TODO: fill in 3rd parameter; {WHO} can be either "unit" or "second_unit" so I dunno how to handle both: 
        
           {MESSAGE ({WHO}) () () _"Traitors! How can you be so dishonorable as to fight against your own rightful king!"}

and:

A_New_Order/scenarios/22_Leaving_Okladia.cfg

Lines 100 to 103 in 3b71676

    
           # FIXME: can't use "{A}" for message captions here because that can lead to the caption being displayed as literally "second_unit": 
        
           {MESSAGE ({A}) () () _"Wait! Before we cross our blades, I must know something. Tell me your name: for I think I saw your face some time ago, and now... Maybe I heard it wrong, but aren't your people calling you Gawen Hagarthen?"} 
        
           {MSGm_Gawen _"I am Gawen Hagarthen."} 
        
           {MESSAGE ({A}) () () _"Gawen Hagarthen, king of Vakladia?"}

cooljeanius · 2021-12-22T02:43:29Z

After ~~PR #17~~ there'll only be like 2 or 3 spots left where this will still be an issue.

OK, so that's merged now... remaining spots that I can see are:

A_New_Order/macros/ano-01_06macros.cfg

Lines 121 to 122 in 3b71676

# TODO: fill in 3rd parameter; {WHO} can be either "unit" or "second_unit" so I dunno how to handle both:

{MESSAGE ({WHO}) () () _"Traitors! How can you be so dishonorable as to fight against your own rightful king!"}

and:

A_New_Order/scenarios/22_Leaving_Okladia.cfg

Lines 100 to 103 in 3b71676

# FIXME: can't use "{A}" for message captions here because that can lead to the caption being displayed as literally "second_unit":

{MESSAGE ({A}) () () _"Wait! Before we cross our blades, I must know something. Tell me your name: for I think I saw your face some time ago, and now... Maybe I heard it wrong, but aren't your people calling you Gawen Hagarthen?"}

{MSGm_Gawen _"I am Gawen Hagarthen."}

{MESSAGE ({A}) () () _"Gawen Hagarthen, king of Vakladia?"}

Would ${WHO}.name and ${A}.name work for these?

cooljeanius · 2022-05-03T11:16:46Z

Update: I found a few more while doing #53

cooljeanius · 2022-10-31T21:27:52Z

Would ${WHO}.name and ${A}.name work for these?

^The "question" tag is for the above... which I guess I could just try and see if it works, but idk, I still kinda want to know if it's supposed to work first...

nemaara · 2022-11-30T06:12:47Z

Your guess is as good as mine unfortunately. I'd say try it out and see if it works...

cooljeanius · 2023-01-04T13:54:02Z

An email from @kele17 has reminded me to check how this affects translatability; will have to look at it later...

cooljeanius · 2023-01-05T03:34:59Z

...so... yeah, after rechecking the [message] documentation, it looks like I'm going to need to add translation marks to all 3rd parameters of the {MESSAGE} parameter, which will be... a lot of busywork, to say the least. And I'm not sure that it can be automated, since some cases need manual review... *sigh*

I can confirm that the idea for changing a message caption here that I'd had in nemaara/A_New_Order#7 works as expected

fix message captions; see nemaara/A_New_Order#7

MultiSeptim · 2023-01-08T12:20:32Z

Looks fine to me.

cooljeanius · 2023-02-27T00:57:42Z

Looks fine to me.

...which part specifically? Are you saying adding translation marks to all the captions would be fine, or that it already looks fine as-is, and I don't need to?

@Toranks

This addresses some feedback from @Toranks Changes include: - addresses issue #7 - clarify Barnon's gold mechanic a bit further - extra debug messages for reinforcement scattering - ensure Gawen is *really* always poisoned in the first scenario - some additional tuning of the second scenario - fix team coloring of kneeling Akladian lords in the coronation cutscene (S03) - additional recruiting space in Barnon on NORMAL, too - fix Hoyre returning on NIGHTMARE; closes issue nemaara#78

@Toranks

…feedback Addresses some feedback from @Toranks Changes include: - addresses issue #7 - clarify Barnon's gold mechanic a bit further (still might need a further update for issue #14 though) - extra debug messages for reinforcement scattering in S04 - ensure Gawen is really always poisoned in the first scenario - some additional tuning of the second scenario - fix team coloring of kneeling Akladian lords in the coronation cutscene (S03) - additional recruiting space in Barnon on NORMAL, too - fix Hoyre returning on NIGHTMARE; closes issue #78

MultiSeptim · 2023-02-28T18:06:30Z

I meant the improvements mentioned before my last comment.

cooljeanius · 2023-03-05T00:02:03Z

PR #117 fixes another case of using the correct name, but doesn't make any decision about adding translation marks or not yet

@Toranks

- add @Toranks to the credits - new portrait for Kyobaine's winter clothing, contributed by OneHourLate, a.k.a. Mells or ohlyf (from Discord, who I also commissioned my last few portraits from) - I made an attempt at improving the issue #19 situation, but it didn't exactly work out to my liking, so it's hidden behind debug mode for now. - New debug mode contextual menu option for displaying messages from arbitrary units, for the purposes of testing issue #16 - Add a macro that I thought I'd included in #109 (and even used there), but looks like I actually forgot... (it's for giving experience to units) - New scenario! This commit includes S15c, "Raedwood East", which is probably enough to fix issue #72 for now (the scenario still isn't fully complete yet, but it's finished enough for the purposes of closing that issue) - Mark more units as unrenamable. Closes issue #114 - Adjust recruitment patterns. Closes issue #116 - fix #112 - Something for issue #7 that I thought I'd already submitted in a previous PR (but, actually hadn't)

…wesnoth-map-diff/json5-2.2.3 Bump json5 from 2.2.0 to 2.2.3 in /utils/wesnoth-map-diff

cooljeanius · 2023-08-15T03:49:09Z

OK so now I'm running the validator on this add-on, and apparently adding translation marks is what the validator wants me to do, so I guess it's time to do that now...

cooljeanius · 2023-08-15T05:04:37Z

one problem with this is that making the message captions translatable often screws up which string certain po: comments get associated with in the potfile... I really ought to just do like the game is telling me and write out the [message] tags in full... or maybe wesnoth/wesnoth#7540 will help once merged...

see nemaara/A_New_Order#7

cooljeanius · 2023-09-06T09:17:17Z

#144 could help simplify this a bit.

cooljeanius · 2023-09-08T05:17:01Z

found another place where there's a caption missing in cooljeanius/A_New_Order@1063046

- new linting workflow - recompression of images - start of work on some lua - validator fixes - updated README see the following issues: - #7 - #32 - #33, checkbox 2 - #57 (a bit) - nemaara#73 (gets started with it at least; I'm holding back on some other parts I've written for it until they're more submittable) - nemaara#81 (adds FIXMEs about it) - nemaara#144

cooljeanius mentioned this issue Apr 21, 2021

Missing message captions cooljeanius/A_New_Order#6

Closed

cooljeanius mentioned this issue Aug 24, 2021

Major content update; should qualify for a 1.4.0 release #17

Merged

cooljeanius added enhancement New feature or request help wanted Extra attention is needed question Further information is requested labels May 29, 2022

cooljeanius mentioned this issue Jan 5, 2023

Update translations #10

Open

cooljeanius added a commit to cooljeanius/A_New_Order that referenced this issue Jan 5, 2023

try improving S02 cutscene a bit

70537a0

I can confirm that the idea for changing a message caption here that I'd had in nemaara/A_New_Order#7 works as expected

cooljeanius added a commit to cooljeanius/A_New_Order that referenced this issue Jan 5, 2023

Update 22_Leaving_Okladia.cfg

fd7a9f0

fix message captions; see nemaara/A_New_Order#7

cooljeanius mentioned this issue Feb 27, 2023

copy over some changes from my other repo #105

Merged

cooljeanius mentioned this issue Mar 4, 2023

Lots of changes! New scenario! New portrait! Bugs fixed! #117

Merged

cooljeanius added a commit that referenced this issue Jul 10, 2023

Merge pull request #7 from cooljeanius/dependabot/npm_and_yarn/utils/…

a3758ab

…wesnoth-map-diff/json5-2.2.3 Bump json5 from 2.2.0 to 2.2.3 in /utils/wesnoth-map-diff

cooljeanius added a commit to cooljeanius/A_New_Order that referenced this issue Aug 15, 2023

more translation marks for message captions

3da2a8c

see nemaara/A_New_Order#7

cooljeanius mentioned this issue Sep 6, 2023

Additional MSG_ macros #144

Closed

cooljeanius referenced this issue in cooljeanius/A_New_Order Sep 8, 2023

validator fixes for S21a

1063046

cooljeanius mentioned this issue Dec 15, 2023

Sync with my other repo (Dec. 2023) #159

Merged

cooljeanius mentioned this issue Jan 1, 2024

Copy over changes from other repo (mostly a continuation of validator fixes) #163

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Missing message captions #7

Missing message captions #7

cooljeanius commented Apr 21, 2021

cooljeanius commented Aug 24, 2021

cooljeanius commented Oct 12, 2021 •

edited

Loading

cooljeanius commented Dec 22, 2021

cooljeanius commented May 3, 2022

cooljeanius commented Oct 31, 2022

nemaara commented Nov 30, 2022

cooljeanius commented Jan 4, 2023

cooljeanius commented Jan 5, 2023

MultiSeptim commented Jan 8, 2023

cooljeanius commented Feb 27, 2023

MultiSeptim commented Feb 28, 2023

cooljeanius commented Mar 5, 2023

cooljeanius commented Aug 15, 2023

cooljeanius commented Aug 15, 2023

cooljeanius commented Sep 6, 2023

cooljeanius commented Sep 8, 2023

Missing message captions #7

Missing message captions #7

Comments

cooljeanius commented Apr 21, 2021

cooljeanius commented Aug 24, 2021

cooljeanius commented Oct 12, 2021 • edited Loading

cooljeanius commented Dec 22, 2021

cooljeanius commented May 3, 2022

cooljeanius commented Oct 31, 2022

nemaara commented Nov 30, 2022

cooljeanius commented Jan 4, 2023

cooljeanius commented Jan 5, 2023

MultiSeptim commented Jan 8, 2023

cooljeanius commented Feb 27, 2023

MultiSeptim commented Feb 28, 2023

cooljeanius commented Mar 5, 2023

cooljeanius commented Aug 15, 2023

cooljeanius commented Aug 15, 2023

cooljeanius commented Sep 6, 2023

cooljeanius commented Sep 8, 2023

cooljeanius commented Oct 12, 2021 •

edited

Loading