Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scenario 10 "Siege of Haeltin" minor nits #32

Closed
2 tasks done
cooljeanius opened this issue Oct 12, 2021 · 5 comments · Fixed by #194
Closed
2 tasks done

Scenario 10 "Siege of Haeltin" minor nits #32

cooljeanius opened this issue Oct 12, 2021 · 5 comments · Fixed by #194
Assignees
@cooljeanius
Labels
enhancement New feature or request
Milestone
1.7.0

Comments

@cooljeanius
Copy link
Collaborator

cooljeanius commented Oct 12, 2021 •
edited
Loading

  • In a previous review, @nemaara said I might want to increase the turn limit; that would require changing the code in a lot of places, though, so I didn't do it at the time. It might be worth revisiting, though.
  • The dialogue about there being "too many of them" should only display if there are, in fact, too many enemies (i.e. the case where they outnumber you... I'm not sure how to filter for that, though)
@cooljeanius
Copy link
Collaborator Author

Alternate idea for checkbox 2: just continue spawning enemies until they do in fact outnumber you

@cooljeanius
Copy link
Collaborator Author

cooljeanius commented Dec 14, 2021 •
edited
Loading

Alternate idea for checkbox 2: just continue spawning enemies until they do in fact outnumber you

either way would require counting the units on your side, though... @Pentarctagon says to do so, just store the side's units to an array and then get the length of the array...

@cooljeanius
Copy link
Collaborator Author

For the first checkbox: PR #53 does some messing with the turn limit

@cooljeanius cooljeanius added the enhancement New feature or request label May 29, 2022
@cooljeanius cooljeanius self-assigned this Aug 16, 2022
@cooljeanius
Copy link
Collaborator Author

oh one more thing about the second checkbox: that line can also be spoken by enemy Akladians, which I think is wrong, since I think the intent was to have it be spoken by one of your own Akladians

cooljeanius referenced this issue in cooljeanius/A_New_Order-1 Jan 1, 2024
@cooljeanius
Copy over changes from other repo
b28e60b 
- new linting workflow
- recompression of images
- start of work on some lua
- validator fixes
- updated README
see the following issues:
- #7
- #32
- #33, checkbox 2
- #57 (a bit)
- nemaara#73 (gets started with it at least; I'm holding back on some other parts I've written for it until they're more submittable)
- nemaara#81 (adds FIXMEs about it)
- nemaara#144
@cooljeanius cooljeanius mentioned this issue Jan 1, 2024
Merged
@cooljeanius cooljeanius added this to the 1.7.0 milestone Apr 7, 2024
cooljeanius added a commit to cooljeanius/A_New_Order that referenced this issue May 21, 2024
@cooljeanius
S10: try to improve dialogue
99250b2 
see nemaara/A_New_Order#32
Meant to fix it, but it got tedious spawning enough units to try to trigger the other branch of the conditional, so it still isn't technically fully tested yet...
@cooljeanius cooljeanius mentioned this issue May 21, 2024
Merged
@cooljeanius
Copy link
Collaborator Author

#194 ought to let us check off the last checkbox, and thus close this.

cooljeanius added a commit that referenced this issue Aug 24, 2024
@cooljeanius
Fixes for issues targeted for Milestone 1.7.0 (#194)
db6054d 
* Start of another PR
  - Another attempt at fixing #23 again; cc @Toranks and @knyghtmare
  - Refer to Gawen as "Haldric" in S08 for #182
  - Dune is probably ok to reference explicitly by name in the translators' comments
  - try Lorin stat changes suggested in #179
* a number of additional minor fixes
  - be more explicit about carryover amounts for issue #14 (still need to check scenarios 20 thru 26)
  - check for Lorin's presence in Kyobaine Easter Egg for issue #150
  - attempt at improving the situation for issue #165 (still broken)
  - Update commentary re: issue #79
  - Updates to dialogue and translation notes for issue #182
  - Enables Raedwood East for normal gameplay for issue #129
  - Give Lorin unique bridge destruction dialogue for issue #187
* a few minor tweaks
* a few additional updates
  - add luacheck workflow
  - add a few additional changelog items
  - dialogue changes for checkbox 2 of issue #32
* Add Rob Roe death message
  - see issue #199
* some more changes from other repo
  - more spellchecking
  - use proper portrait for Kyobaine in her death message
  - tried to add a new fix for #79, but it doesn't seem to work...
  - a few more footnotes
* latest batch of changes from other repo
(squashed)
cooljeanius added a commit that referenced this issue Aug 25, 2024
@cooljeanius
Merge pull request #32 from cooljeanius/dependabot/submodules/utils/w…
729e574 
…esnoth-map-diff-bbc4864

Bump utils/wesnoth-map-diff from `966a274` to `bbc4864`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cooljeanius cooljeanius

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.7.0
Development

Successfully merging a pull request may close this issue.

Fixes for issues targeted for Milestone 1.7.0 cooljeanius/A_New_Order-1
1 participant
@cooljeanius