Revert "Stop recognizing UTF16_Encoder.encodeUTF16 methods" (2) #7578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This commit depends on #7577 and eclipse-openj9/openj9#20722. |
This commit restores the changes for encodeUTF16Big and encodeUTF16Little that were removed by eclipse-omr#7548. Signed-off-by: KONNO Kazuhiro <[email protected]>
knn-k
force-pushed
the
revertEncodeUTF16_2
branch
from
8b68282 to
f70af00
Compare
|
Jenkins build all |
|
I changed the enum symbols |
|
@knn-k, I think this change looks good. I will wait for you to mark it as "Ready for review" before merging. |
knn-k
requested review from
vijaysun-omr,
dsouzai,
0xdaryl and
mstoodle
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit restores the changes for encodeUTF16Big and encodeUTF16Little that were removed by #7548.