-
Notifications
You must be signed in to change notification settings - Fork 728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop recognizing UTF16_Encoder.encodeUTF16 methods #20613
Conversation
Jenkins test sanity plinux,,xlinux,zlinux jdk11 |
9e92901
to
1a4ccdc
Compare
Jenkins test sanity plinux,,xlinux,zlinux jdk11 |
Jenkins test sanity plinux,,xlinux,zlinux jdk11 depends eclipse-omr/omr#7548 |
@hzongaro FYI. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It think the changes look good. May I ask you to correct the name of the class in the commit message? I believe it was named sun.nio.cs.UTF16_Encoder
This commit removes the code for encodeUTF16Big() and encodeUTF16Little() methods in sun.nio.cs.UTF16_Encoder from method recognition, and removes related helper functions. Signed-off-by: KONNO Kazuhiro <[email protected]>
1a4ccdc
to
5e8ada3
Compare
I corrected the class name in the commit title and the commit message. |
Jenkins test sanity plinux,xlinux,zlinux jdk11 depends eclipse-omr/omr#7548 |
The test failure on x390x_linux looks the same as Issue #13756. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks!
As this will require a coordinated merge with eclipse-omr/omr#7548, I will run further testing as required by the Guide for Committers. Jenkins test sanity.functional,sanity.openjdk all jdk8,jdk11,jdk17,jdk21 depends eclipse-omr/omr#7548 |
Shall I split the PRs into smaller ones so that they don't require a coordinated merge? |
No worries! Let's just go ahead with these PRs as they are. Windows builds are out of commission at the moment, so those failures are expected. I will restart the other failing builds. Jenkins test sanity.functional xmac jdk8 depends eclipse-omr/omr#7548 |
Jenkins test sanity.openjdk xmac jdk17,jdk21 depends eclipse-omr/omr#7548 |
Jenkins test sanity.functional plinux jdk11,jdk21 depends eclipse-omr/omr#7548 |
The only failures appear to be due to known issues. I will perform the coordinated merge with eclipse-omr/omr#7548 as soon as the same commit appears at the tips of the |
This commit restores the changes for encodeUTF16Big and encodeUTF16Little that were removed by eclipse-openj9#20613. Signed-off-by: KONNO Kazuhiro <[email protected]>
My apologies. |
I opened PRs #20722, eclipse-omr/omr#7577, and eclipse-omr/omr#7578 for reverting the changes of |
@knn-k, thank you for catching this! I'm sorry that I missed that while reviewing. |
This commit restores the changes for encodeUTF16Big and encodeUTF16Little that were removed by eclipse-openj9#20613. Signed-off-by: KONNO Kazuhiro <[email protected]>
This commit removes the code for encodeUTF16Big() and encodeUTF16Little() methods in sun.nio.cs.UTF16_Encoder from method recognition, and removes related helper functions.