Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Stop recognizing UTF16_Encoder.encodeUTF16 methods" #20722

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Revert "Stop recognizing UTF16_Encoder.encodeUTF16 methods" #20722

merged 1 commit into from
Dec 6, 2024

Conversation

knn-k
Copy link
Contributor

@knn-k knn-k commented Dec 2, 2024

This commit restores the changes for encodeUTF16Big and encodeUTF16Little that were removed by #20613.

@knn-k
Revert "Stop recognizing UTF16_Encoder.encodeUTF16 methods"
29810b6 
This commit restores the changes for encodeUTF16Big and encodeUTF16Little
that were removed by eclipse-openj9#20613.

Signed-off-by: KONNO Kazuhiro <[email protected]>
@knn-k knn-k added comp:jit depends:omr Pull request is dependent on a corresponding change in OMR arch:power arch:x86 arch:z labels Dec 2, 2024
@knn-k
Copy link
Contributor Author

knn-k commented Dec 2, 2024

Jenkins test sanity plinux,xlinux,zlinux jdk8 depends eclipse-omr/omr#7577

@knn-k
Copy link
Contributor Author

knn-k commented Dec 2, 2024

I split the changes in the OMR side into two PRs to avoid coordinated merge.

@knn-k
Copy link
Contributor Author

knn-k commented Dec 2, 2024 •
edited
Loading

No need for coordinated merge:

I changed the enum symbols sun_nio_cs_UTF_16_Encoder_encodeUTF16Big and sun_nio_cs_UTF_16_Encoder_encodeUTF16Little to sun_nio_cs_UTF16_Encoder_encodeUTF16Big and sun_nio_cs_UTF16_Encoder_encodeUTF16Little by removing the _ between UTF and 16 in this PR to avoid confusion, because the class name is sun/nio/cs/UTF16_Encoder.

This was referenced Dec 2, 2024
Merged
Merged
@knn-k
Copy link
Contributor Author

knn-k commented Dec 3, 2024

The test failure on xlinux Java 8 is a known issue: #18599

@knn-k
Copy link
Contributor Author

knn-k commented Dec 3, 2024

Jenkins test sanity plinux,xlinux,zlinux jdk8 depends eclipse-omr/omr#7578

@knn-k
Copy link
Contributor Author

knn-k commented Dec 4, 2024

Jenkins test sanity plinux,xlinux,zlinux jdk11 depends eclipse-omr/omr#7578

@knn-k
Copy link
Contributor Author

knn-k commented Dec 4, 2024

Some failures with JITServerTest using Java 11 on plinux: https://openj9-jenkins.osuosl.org/job/Test_openjdk11_j9_sanity.functional_ppc64le_linux_Personal_testList_0/366/

@hzongaro
Copy link
Member

hzongaro commented Dec 5, 2024

JITServerTest failure in JDK 11 plinux testing should be fixed by pull request #20757

@pshipton
Copy link
Member

pshipton commented Dec 5, 2024

I've promoted OMR.

@hzongaro
Copy link
Member

hzongaro commented Dec 5, 2024 •
edited
Loading

It looks like pull request eclipse-omr/omr#7577 has been merged promoted, so you should be able to move this pull request to "Ready for review" status.

hzongaro
hzongaro approved these changes Dec 5, 2024
View reviewed changes
Copy link
Member

@hzongaro hzongaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the changes look good. Thanks!

@knn-k knn-k marked this pull request as ready for review December 5, 2024 21:33
@knn-k knn-k requested a review from dsouzai as a code owner December 5, 2024 21:33
@hzongaro
Copy link
Member

hzongaro commented Dec 6, 2024

Testing with both eclipse-omr/omr#7577 and eclipse-omr/omr#7578 only failed due to known issues. Merging.

@hzongaro hzongaro merged commit 9725406 into eclipse-openj9:master Dec 6, 2024
16 of 21 checks passed
@knn-k knn-k deleted the revertEncodeUTF16 branch December 6, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hzongaro hzongaro hzongaro approved these changes

@dsouzai dsouzai Awaiting requested review from dsouzai dsouzai is a code owner

Assignees
No one assigned
Labels
arch:power arch:x86 arch:z comp:jit depends:omr Pull request is dependent on a corresponding change in OMR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@knn-k @hzongaro @pshipton