chore: cleanup out-of-date TODOs

[njzjz]

Closes #3521. Cloases #3532.

Summary by CodeRabbit

• Refactor
  • Removed outdated TODO comments for cleaner codebase.
  • Updated function calls for better consistency in descriptor handling.

[coderabbitai]

Walkthrough

Walkthrough

The changes involve minor cleanups in the deepmd codebase: removing a TODO comment related to porting a function to pathlib in common.py and updating a method call in env_mat_stat.py by replacing get_rcut with get_rcut_smth.

Changes

File Path	Change Summary
deepmd/common.py	Removed a TODO comment for porting expand_sys_str function to pathlib
deepmd/pt/utils/env_mat_stat.py	Updated method call from get_rcut to get_rcut_smth in DescriptorBlock

Assessment against linked issues

Objective	Addressed	Explanation
Port expand_sys_str completely to pathlib when all callers are ported (#3521)	❌	Only the TODO comment was removed; no porting to pathlib was done.
Update self.descriptor.get_rcut() to self.descriptor.get_rcut_smth() (#3521)	✅

---

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 02e4ce9 and 00527f9.

Files selected for processing (2)

• deepmd/common.py (1 hunks)
• deepmd/pt/utils/env_mat_stat.py (1 hunks)

Files skipped from review due to trivial changes (2)

• deepmd/common.py
• deepmd/pt/utils/env_mat_stat.py

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.50%. Comparing base (02e4ce9) to head (00527f9).

Additional details and impacted files

@@           Coverage Diff           @@
##            devel    #3811   +/-   ##
=======================================
  Coverage   82.50%   82.50%           
=======================================
  Files         516      516           
  Lines       49049    49049           
  Branches     2983     2982    -1     
=======================================
  Hits        40466    40466           
  Misses       7672     7672           
  Partials      911      911           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.