Skip to content

Commit

Permalink
chore: cleanup out-of-date TODOs (#3811)
Browse files Browse the repository at this point in the history
Closes #3521. Cloases #3532.

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Refactor**
  - Removed outdated TODO comments for cleaner codebase.
- Updated function calls for better consistency in descriptor handling.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

Co-authored-by: Duo <[email protected]>
  • Loading branch information
njzjz and iProzd authored May 24, 2024
1 parent 6aac9f8 commit 0e67a7e
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 2 deletions.
1 change: 0 additions & 1 deletion deepmd/common.py
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,6 @@ def j_loader(filename: Union[str, Path]) -> Dict[str, Any]:
raise TypeError("config file must be json, or yaml/yml")


# TODO port expand_sys_str completely to pathlib when all callers are ported
def expand_sys_str(root_dir: Union[str, Path]) -> List[str]:
"""Recursively iterate over directories taking those that contain `type.raw` file.
Expand Down
1 change: 0 additions & 1 deletion deepmd/pt/utils/env_mat_stat.py
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,6 @@ def iter(
zero_mean,
one_stddev,
self.descriptor.get_rcut(),
# TODO: export rcut_smth from DescriptorBlock
self.descriptor.get_rcut_smth(),
radial_only,
protection=self.descriptor.get_env_protection(),
Expand Down

0 comments on commit 0e67a7e

Please sign in to comment.