Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

port expand_sys_str completely to pathlib when all callers are ported #3521

Closed
github-actions bot opened this issue Mar 19, 2024 · 3 comments · Fixed by #3811
Closed

port expand_sys_str completely to pathlib when all callers are ported #3521

github-actions bot opened this issue Mar 19, 2024 · 3 comments · Fixed by #3811
Labels
branch: devel todo comment type: todo

Comments

@github-actions
Copy link

Line: 243

deepmd-kit//deepmd/common.py

Lines 240 to 250 in 76371ce

raise TypeError("config file must be json, or yaml/yml")
# TODO port expand_sys_str completely to pathlib when all callers are ported
def expand_sys_str(root_dir: Union[str, Path]) -> List[str]:
"""Recursively iterate over directories taking those that contain `type.raw` file.
Parameters
----------
root_dir : Union[str, Path]
starting directory

@njzjz
Copy link
Member

njzjz commented May 21, 2024

I guess we can remove this comment.

@wanghan-iapcm
Copy link
Collaborator

+1

njzjz added a commit to njzjz/deepmd-kit that referenced this issue May 22, 2024
@njzjz
chore: cleanup out-of-date TODOs
2f69723 
Closes deepmodeling#3521. Cloases deepmodeling#3532.
@njzjz njzjz mentioned this issue May 22, 2024
Merged
@njzjz njzjz linked a pull request May 22, 2024 that will close this issue
chore: cleanup out-of-date TODOs #3811
Merged
github-merge-queue bot pushed a commit that referenced this issue May 24, 2024
@njzjz @iProzd
chore: cleanup out-of-date TODOs (#3811)
0e67a7e 
Closes #3521. Cloases #3532.

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Refactor**
  - Removed outdated TODO comments for cleaner codebase.
- Updated function calls for better consistency in descriptor handling.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

Co-authored-by: Duo <[email protected]>
@github-actions GitHub Actions
Copy link
Author

Closed in commit 0e67a7e

mtaillefumier pushed a commit to mtaillefumier/deepmd-kit that referenced this issue Sep 18, 2024
@njzjz @iProzd
chore: cleanup out-of-date TODOs (deepmodeling#3811)
a9343bc 
Closes deepmodeling#3521. Cloases deepmodeling#3532.

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Refactor**
  - Removed outdated TODO comments for cleaner codebase.
- Updated function calls for better consistency in descriptor handling.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

Co-authored-by: Duo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
branch: devel todo comment type: todo
Projects
No open projects
DeePMD-3.0.0 beta release
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: cleanup out-of-date TODOs njzjz/deepmd-kit
2 participants
@njzjz @wanghan-iapcm