Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

export rcut_smth from DescriptorBlock #3532

Closed
github-actions bot opened this issue Mar 19, 2024 · 2 comments · Fixed by #3761 or #3811
Closed

export rcut_smth from DescriptorBlock #3532

github-actions bot opened this issue Mar 19, 2024 · 2 comments · Fixed by #3761 or #3811
Assignees
@wanghan-iapcm
Labels
branch: devel todo comment type: todo
Milestone
v3.0.0

Comments

@github-actions
Copy link

Line: 144

deepmd-kit//deepmd/pt/utils/env_mat_stat.py

Lines 141 to 151 in 76371ce

zero_mean,
one_stddev,
self.descriptor.get_rcut(),
# TODO: export rcut_smth from DescriptorBlock
self.descriptor.rcut_smth,
radial_only,
protection=self.descriptor.env_protection,
)
# reshape to nframes * nloc at the atom level,
# so nframes/mixed_type do not matter
env_mat = env_mat.view(

@njzjz njzjz added this to the v3.0.0 milestone Mar 19, 2024
@iProzd iProzd moved this to Backlog in DeePMD-3.0.0 beta release Apr 30, 2024
@wanghan-iapcm wanghan-iapcm linked a pull request May 9, 2024 that will close this issue
feat: descriptor provide get_rcut_smth and get_env_protection #3761
Merged
@njzjz
Copy link
Member

njzjz commented May 16, 2024

Although it has been resolved, the TODO tag still exists.

njzjz added a commit to njzjz/deepmd-kit that referenced this issue May 22, 2024
@njzjz
chore: cleanup out-of-date TODOs
2f69723 
Closes deepmodeling#3521. Cloases deepmodeling#3532.
@njzjz njzjz mentioned this issue May 22, 2024
Merged
@njzjz njzjz linked a pull request May 22, 2024 that will close this issue
chore: cleanup out-of-date TODOs #3811
Merged
github-merge-queue bot pushed a commit that referenced this issue May 24, 2024
@njzjz @iProzd
chore: cleanup out-of-date TODOs (#3811)
0e67a7e 
Closes #3521. Cloases #3532.

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Refactor**
  - Removed outdated TODO comments for cleaner codebase.
- Updated function calls for better consistency in descriptor handling.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

Co-authored-by: Duo <[email protected]>
@github-actions GitHub Actions
Copy link
Author

Closed in commit 0e67a7e

@github-project-automation github-project-automation bot moved this from Backlog to Done in DeePMD-3.0.0 beta release May 24, 2024
mtaillefumier pushed a commit to mtaillefumier/deepmd-kit that referenced this issue Sep 18, 2024
@njzjz @iProzd
chore: cleanup out-of-date TODOs (deepmodeling#3811)
a9343bc 
Closes deepmodeling#3521. Cloases deepmodeling#3532.

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Refactor**
  - Removed outdated TODO comments for cleaner codebase.
- Updated function calls for better consistency in descriptor handling.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

Co-authored-by: Duo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wanghan-iapcm wanghan-iapcm

Labels
branch: devel todo comment type: todo
Projects
Multiple backend support for DeePMD-kit
Archived in project
DeePMD-3.0.0 beta release
Archived in project
Milestone
v3.0.0
2 participants
@njzjz @wanghan-iapcm