fix: use copy(v) which works also on str, instead of v.copy() which doesn't #5417
Conversation
…oesn't resolves conda#5416 resolves conda#3404 (closed because stale, not because fixed) Bug was possibly introduced in conda#3344
|
We require contributors to sign our Contributor License Agreement and we don't have one on file for @corneliusroemer. In order for us to review and merge your code, please e-sign the Contributor License Agreement PDF. We then need to manually verify your signature, merge the PR (conda/infrastructure#965), and ping the bot to refresh the PR. |
CodSpeed Performance ReportMerging #5417 will not alter performanceComparing Summary
|
|
@conda-bot check |
conda-bot
added
the
cla-signed
|
Thanks for opening this. While we wait for the others to chime in, it would be really nice if you could add both a regression test for this and a news file entry. The regression test could go in The tricky part is finding the exact data to feed into the function to recreate the stacktrace, but I hope that you might be able to generate that seeing that you can recreate this issue yourself. Let us know if you need any help with that. |
|
Thanks @travishathaway! Happy to add news and try to get a test working - just wanted to check I'd not be wasting my time. |
* fix: catch user errors in `distribute_variants` * fix: catch a few more SystemExits * test: add test to ensure undefine jinja2 is OK * doc: add news
updates: - [github.com/astral-sh/ruff-pre-commit: v0.7.3 → v0.7.4](astral-sh/ruff-pre-commit@v0.7.3...v0.7.4) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
|
Please add a test and news, and then we can merge. This PR won't make a version of conda-build until next year. |
…#5555) * fix: allow incomplete specs if undefined jinja2 * refactor: skip it instead * refactor: simpler * style: pre the commit * style: no extra whitespace * test: add test * test: fix tests
|
OK @conda/builds-tools This one is ready for review! This bug is serious enough that it may make sense to include it as a bug fix release for 24.11. Thoughts? |
resolves #5416
resolves #3404 (closed because stale, not because fixed)
Bug was possibly introduced in #3344
@msarahan @isuruf I think you are best acquainted with this part of the code base. I don't really know what's going on here - but this workaround fixes the bug for my use case.
Checklist - did you ...
Will fill out checklist if it's likely this will get merged
newsdirectory (using the template) for the next release's release notes?