Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mlflow 2.18.0: make a multi-output recipe #9

Closed
wants to merge 7 commits into from

Conversation

skupr-anaconda
Copy link

@skupr-anaconda skupr-anaconda commented Nov 26, 2024

Destination channel: main

Links

Explanation of changes:

  • Rewriting as a multi-output recipe because of catching a conda-build bug on win-64 (see the previous draft PR mlflow 2.18.0 #8), the fix won't be available until the next release of conda-build in January 2025 (???), see fix: use copy(v) which works also on str, instead of v.copy() which doesn't conda/conda-build#5417
  • Make changes based on the conda-forge recipe:
    • Add README_SKINNY.rst
    • Add build-mlflow.bat and build-mlflow.sh
    • Remove conda_build_config.yaml as we do not rely on jinja2 variants and selectors.
  • Skip py<39
  • Add to run_constrained:
    • mlflow <0a0 for the mlflow-skinny subpackage to prevent installing mlflow to the same environment
    • mlflow-skinny <0a0 for the mlflow subpackage to prevent installing mlflow-skinny to the same environment
  • Add separate about sections to every output. They have different summaries and descriptions

Notes:

@skupr-anaconda skupr-anaconda self-assigned this Nov 26, 2024
@anaconda-pkg-build
Copy link

Linter check found the following problems: ERROR conda.cli.main_run:execute(125): `conda run conda-lint /tmp/abs_22v_bypv13/clone` failed. (See above for error) The following problems have been found:

===== WARNINGS =====

  • clone/recipe/meta.yaml:180: missing_description: The recipe is missing a description

===== ERRORS =====

  • clone/recipe/meta.yaml:43: version_constraints_missing_whitespace: output "mlflow-skinny": Packages and their version constraints must be space separated
  • clone/recipe/meta.yaml:119: version_constraints_missing_whitespace: output "mlflow": Packages and their version constraints must be space separated
  • clone/recipe/meta.yaml:44: version_constraints_missing_whitespace: output "mlflow-skinny": Packages and their version constraints must be space separated
  • clone/recipe/meta.yaml:37: version_constraints_missing_whitespace: output "mlflow-skinny": Packages and their version constraints must be space separated
  • clone/recipe/meta.yaml:121: version_constraints_missing_whitespace: output "mlflow": Packages and their version constraints must be space separated
    ===== Final Report: =====
    5 Errors and 1 Warning were found

@anaconda-pkg-build
Copy link

Linter check found the following problems: ERROR conda.cli.main_run:execute(125): `conda run conda-lint /tmp/abs_d083hg95u5/clone` failed. (See above for error) The following problems have been found:

===== WARNINGS =====

  • clone/recipe/meta.yaml:253: missing_description: The recipe is missing a description

===== ERRORS =====

  • clone/recipe/meta.yaml:40: version_constraints_missing_whitespace: output "mlflow-skinny": Packages and their version constraints must be space separated
  • clone/recipe/meta.yaml:47: version_constraints_missing_whitespace: output "mlflow-skinny": Packages and their version constraints must be space separated
  • clone/recipe/meta.yaml:46: version_constraints_missing_whitespace: output "mlflow-skinny": Packages and their version constraints must be space separated
    ===== Final Report: =====
    3 Errors and 1 Warning were found

@anaconda-pkg-build
Copy link

Linter check found the following problems: ERROR conda.cli.main_run:execute(125): `conda run conda-lint /tmp/abs_7firw8adf1/clone` failed. (See above for error) The following problems have been found:

===== WARNINGS =====

  • clone/recipe/meta.yaml:253: missing_description: The recipe is missing a description

===== ERRORS =====

  • clone/recipe/meta.yaml:46: version_constraints_missing_whitespace: output "mlflow-skinny": Packages and their version constraints must be space separated
  • clone/recipe/meta.yaml:47: version_constraints_missing_whitespace: output "mlflow-skinny": Packages and their version constraints must be space separated
  • clone/recipe/meta.yaml:40: version_constraints_missing_whitespace: output "mlflow-skinny": Packages and their version constraints must be space separated
    ===== Final Report: =====
    3 Errors and 1 Warning were found

@skupr-anaconda skupr-anaconda marked this pull request as ready for review November 26, 2024 13:16
@skupr-anaconda skupr-anaconda changed the title split 2.18.0 mlflow 2.18.0: make a multi-output recipe Nov 26, 2024
Copy link

@cbouss cbouss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with some pedantic suggestions.

recipe/meta.yaml Outdated Show resolved Hide resolved
recipe/meta.yaml Outdated Show resolved Hide resolved
@skupr-anaconda
Copy link
Author

@cbouss I'll wait for conda-build 24.11.2 to be deployed on Prefect. Today, there is still 24.11.1. Then, this PR will be superseded by #8 where changes are minimal.

@skupr-anaconda skupr-anaconda mentioned this pull request Nov 27, 2024
@anaconda-pkg-build
Copy link

Linter check found the following problems: ERROR conda.cli.main_run:execute(125): `conda run conda-lint /tmp/abs_cdjg821p05/clone` failed. (See above for error) The following problems have been found:

===== WARNINGS =====

  • clone/recipe/meta.yaml:253: missing_description: The recipe is missing a description
    ===== Final Report: =====
    0 Errors and 1 Warning were found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants