Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: carry patch for conda-build#5417 #234

Merged

Conversation

conda-forge-admin
Copy link
Contributor

@conda-forge-admin conda-forge-admin commented Nov 26, 2024

This PR adds a patch from conda/conda-build#5417 since the bug is rather pressing and we'll wait for a release for a bit.

Fixes #233

@conda-forge-admin
Copy link
Contributor Author

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@conda-forge-admin conda-forge-admin marked this pull request as ready for review November 26, 2024 11:22
@beckermr beckermr changed the title MNT: rerender fix: carry patch for conda-build#5417 Nov 26, 2024
@beckermr
Copy link
Member

@conda-forge-admin rerender

@conda-forge-admin
Copy link
Contributor Author

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12029585721. Examine the logs at this URL for more detail.

@beckermr
Copy link
Member

@conda-forge/core @h-vetinari thoughts on this one? Shall we merge?

@beckermr
Copy link
Member

Copy link
Member

@h-vetinari h-vetinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!

Given the prevalence with which this now occurs, I think we need to do this

recipe/meta.yaml Outdated Show resolved Hide resolved
@beckermr beckermr added the automerge Merge the PR when CI passes label Nov 26, 2024
@conda-forge-admin conda-forge-admin merged commit 54f3fac into conda-forge:main Nov 26, 2024
27 checks passed
@conda-forge-admin
Copy link
Contributor Author

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@conda-forge-admin rerender
3 participants