Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CUDA Enhanced Compatibility on CUDA 12 #201

Merged

Conversation

conda-forge-admin
Copy link
Contributor

@conda-forge-admin conda-forge-admin commented Nov 26, 2024

Updates the CUDA 12 logic to support CUDA Enhanced Compatibility given conda-forge has migrated from CUDA 12.0 to 12.6 ( conda-forge/conda-forge-pinning-feedstock#6720 )

Fixes #200

@conda-forge-admin
Copy link
Contributor Author

conda-forge-admin commented Nov 26, 2024

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). Your recipe may not receive automatic updates and/or may not be compatible with conda-forge's infrastructure. Please check the logs for more information and ensure your recipe can be parsed.
  • ℹ️ The recipe is not parsable by parser conda-recipe-manager. Your recipe may not receive automatic updates and/or may not be compatible with conda-forge's infrastructure. Please check the logs for more information and ensure your recipe can be parsed.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12036937564. Examine the logs at this URL for more detail.

@jakirkham
Copy link
Member

@conda-forge-admin , please re-render

@conda-forge-admin
Copy link
Contributor Author

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12036729487. Examine the logs at this URL for more detail.

@jakirkham jakirkham changed the title MNT: rerender Use CUDA Enhanced Compatibility on CUDA 12 Nov 26, 2024
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One optional suggestion, otherwise looks fine.

recipe/meta.yaml Outdated Show resolved Hide resolved
recipe/meta.yaml Outdated Show resolved Hide resolved
@jakirkham
Copy link
Member

@conda-forge-admin , please re-render

@conda-forge-admin
Copy link
Contributor Author

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12036972860. Examine the logs at this URL for more detail.

@jakirkham jakirkham added the automerge Merge the PR when CI passes label Nov 26, 2024
@jakirkham
Copy link
Member

Note that the Windows build failure is due to a conda-build bug: conda/conda-build#5417

Conda-forge added the bug fix as a patch ( conda-forge/conda-build-feedstock#234 ), but it may still be mirroring to CDN

Will try restarting in a bit

@conda-forge-admin
Copy link
Contributor Author

conda-forge-admin commented Nov 26, 2024

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed
  • rerender called: passed

Thus the PR was passing and merged! Have a great day!

@conda-forge-admin conda-forge-admin merged commit d213489 into conda-forge:main Nov 26, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update CUDA 12 handling (in light of move to CUDA 12.6)
3 participants