Speed up rendering by avoiding costly/redundant function calls #5248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conda-bot
added
the
cla-signed
mbargull
force-pushed
the
render-speedups-func-calls
branch
from
7a6ec16 to
dd6d546
Compare
CodSpeed Performance ReportMerging #5248 will improve performances by 63.68%Comparing Summary
Benchmarks breakdown
|
mbargull
force-pushed
the
render-speedups-func-calls
branch
from
dd6d546 to
c5a74b3
Compare
mbargull
changed the title
mbargull
force-pushed
the
render-speedups-func-calls
branch
from
937552c to
f208ed3
Compare
mbargull
commented
Mar 21, 2024
Comment on lines
+1
to
+19
| ### Enhancements | ||
|
|
||
| * Speed up rendering by avoiding costly/redundant function calls. (#5248) | ||
|
|
||
| ### Bug fixes | ||
|
|
||
| * <news item> | ||
|
|
||
| ### Deprecations | ||
|
|
||
| * <news item> | ||
|
|
||
| ### Docs | ||
|
|
||
| * <news item> | ||
|
|
||
| ### Other | ||
|
|
||
| * <news item> |
There was a problem hiding this comment.
I'm impartial on whether we should or should not include this news entry (meaning, I don't necessarily consider this a "significant" change).
We can include it if we want to track such changes more obviously or exclude it to reduce noise in the changelog 🤷 .
2 tasks
kenodegard
reviewed
Mar 22, 2024
kenodegard
reviewed
Mar 22, 2024
kenodegard
reviewed
Mar 22, 2024
| @@ -1665,7 +1666,6 @@ def build_id(self): | |||
| raise RuntimeError( | |||
| f"Couldn't extract raw recipe text for {self.name()} output" | |||
| ) | |||
| raw_recipe_text = self.extract_package_and_build_text() | |||
There was a problem hiding this comment.
I wonder how much of a speedup removing this gives us (since both of us did this)
3 tasks
Signed-off-by: Marcel Bargull <[email protected]>
Signed-off-by: Marcel Bargull <[email protected]>
Signed-off-by: Marcel Bargull <[email protected]>
Signed-off-by: Marcel Bargull <[email protected]>
Signed-off-by: Marcel Bargull <[email protected]>
Signed-off-by: Marcel Bargull <[email protected]>
mbargull
force-pushed
the
render-speedups-func-calls
branch
from
f208ed3 to
2a8ddb2
Compare
Signed-off-by: Marcel Bargull <[email protected]> Co-authored-by: Ken Odegard <[email protected]> Signed-off-by: Marcel Bargull <[email protected]>
mbargull
force-pushed
the
render-speedups-func-calls
branch
from
2a8ddb2 to
989cb90
Compare
This was referenced Apr 12, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Address some points of gh-5224.
This cherry-picks small (hopefully) non-controversial parts from gh-5225.
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?[ ] Add / update necessary tests?[ ] Add / update outdated documentation?