Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Short-circuit get_output_dicts_from_metadata's if clause for faster evaluation #5278

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

kenodegard
Copy link
Contributor

@kenodegard kenodegard commented Apr 12, 2024

Description

Reorders if-clause to run cheaper (faster) calculation first and more expensive calculation second so we can benefit from short-circuiting.

Split from:

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Apr 12, 2024
Copy link

codspeed-hq bot commented Apr 12, 2024

CodSpeed Performance Report

Merging #5278 will not alter performance

Comparing kenodegard:if-short-circuit (aeafe1f) with main (6982cbd)

Summary

✅ 3 untouched benchmarks

@kenodegard kenodegard marked this pull request as ready for review April 12, 2024 20:27
@kenodegard kenodegard requested a review from a team as a code owner April 12, 2024 20:27
@kenodegard kenodegard merged commit 51793ce into conda:main Apr 17, 2024
30 checks passed
@kenodegard kenodegard deleted the if-short-circuit branch April 17, 2024 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants