Minor refactor of find_used_variables_* functions
#5296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conda-bot
added
the
cla-signed
CodSpeed Performance ReportMerging #5296 will not alter performanceComparing Summary
|
beckermr
approved these changes
Apr 18, 2024
jezdez
approved these changes
Apr 18, 2024
| if ( | ||
| variant in text # str in str is faster than re.search | ||
| and re.search( | ||
| rf"(^[^$]*?\$\{{?\s*{re.escape(variant)}\s*[\s|\}}])", |
There was a problem hiding this comment.
Would it be useful to compile and cache this?
There was a problem hiding this comment.
not any more than re already does since we're formatting the pattern with the variant in each iteration
beeankha
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This refactor adds a
variant in textcheck before calling the more expensivere.search(PATTERN % variant, text). And while working on this went ahead and added a unittest!Extracted from:
Extends #5283
Checklist - did you ...
Add a file to thenewsdirectory (using the template) for the next release's release notes?Add / update outdated documentation?