Remove/avoid redundant function calls #5280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcel Bargull <[email protected]>
conda-bot
added
the
cla-signed
CodSpeed Performance ReportMerging #5280 will not alter performanceComparing Summary
|
This was referenced Apr 12, 2024
beeankha
previously approved these changes
Apr 15, 2024
jakirkham
reviewed
Apr 16, 2024
conda_build/variants.py
Outdated
Comment on lines
707
to
712
| loop_vars = [ | ||
| k | ||
| for k in variants[0] | ||
| for k, v in first_variant.items() | ||
| if k not in special_keys | ||
| and ( | ||
| not loop_only | ||
| or any(variant[k] != variants[0][k] for variant in variants[1:]) | ||
| ) | ||
| and (not loop_only or any(variant[k] != v for variant in other_variants)) | ||
| ] |
There was a problem hiding this comment.
Could this also be written in terms of sets?
There was a problem hiding this comment.
Added a unittest and tinkered some more, see https://github.com/conda/conda-build/compare/6f0474b337583ef357e0244339df116d921940a4..40de0ae1c195ef9c3e6974630d576c96ea64506a
kenodegard
commented
Apr 17, 2024
Comment on lines
+704
to
+705
| @deprecated.argument("24.5", "24.7", "loop_only") | ||
| def get_vars(variants: Iterable[dict[str, Any]]) -> set[str]: |
There was a problem hiding this comment.
Opted to deprecate loop_only since get_vars is only invoked from one place and for that call loop_only=True (see conda_build.metadata.MetaData.get_loop_vars).
jezdez
approved these changes
Apr 17, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Drive-by improvements:
setoperations instead offor-loop +if-clauseset.updateSplit from:
extract_package_and_build_textcall #5253Checklist - did you ...
Add a file to thenewsdirectory (using the template) for the next release's release notes?Add / update necessary tests?Add / update outdated documentation?