Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recipe for urchin #22592

Merged
merged 3 commits into from
Apr 20, 2023
Merged

Add recipe for urchin #22592

merged 3 commits into from
Apr 20, 2023

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Apr 17, 2023

urchin started as a mantainance fork of abandoned urdfpy package that is already in conda-forge, but then was converted to a completly different package with its own name and that can be installed side-by-side with urdfpy to continue its development.

urchin repo: https://github.com/fishbotics/urchin .
urchin PyPI: https://pypi.org/project/urchin/ .

See mmatl/urdfpy#31 for more detail.

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/urchin) and found some lint.

Here's what I've got...

For recipes/urchin:

  • noarch: python recipes are required to have a lower bound on the python version. Typically this means putting python >=3.6 in both host and run but you should check upstream for the package's Python compatibility.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/urchin) and found it was in an excellent condition.

@traversaro
Copy link
Contributor Author

@conda-forge/staged-recipes @conda-forge/help-python the recipe is ready for review, thanks! It is a classical recipe for a python package already on PyPI.

recipes/urchin/meta.yaml Outdated Show resolved Hide resolved
@traversaro traversaro requested a review from ocefpaf April 20, 2023 08:51
@ocefpaf ocefpaf merged commit eed5379 into conda-forge:main Apr 20, 2023
@traversaro
Copy link
Contributor Author

Thaks @ocefpaf!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants