Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pycollada strict pin to 0.6.0 ? #2

Closed
traversaro opened this issue Apr 17, 2023 · 5 comments
Closed

pycollada strict pin to 0.6.0 ? #2

traversaro opened this issue Apr 17, 2023 · 5 comments

Comments

@traversaro
Copy link
Collaborator

I was trying to package urchin for conda-forge in conda-forge/staged-recipes#22592, and I noticed that urchin still has a strict pin of pycollada to 0.6.0 in

"pycollada==0.6", # COLLADA (.dae) mesh loading via trimesh
. This creates problem as pycollada 0.6.0 is not available in conda-forge. Is this strict pin intentional?

@fishbotics

@fishbotics
Copy link
Owner

I didn't pin this for any specific reason. We can unpin it and test whether it breaks.

@fishbotics
Copy link
Owner

Which--relatedly--means we should probably add tests

@traversaro
Copy link
Collaborator Author

Which--relatedly--means we should probably add tests

At least for running the tests that were already in urdfpy #1 should work fine.

@fishbotics
Copy link
Owner

I unpinned it with #4. I just pushed it without a MR because the change is so small, but in general, I'll stick to MRs.

@traversaro
Copy link
Collaborator Author

I unpinned it with #4. I just pushed it without a MR because the change is so small, but in general, I'll stick to MRs.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants