New onboarding changes android

[deeppandya]

Resolves brave/brave-browser#42863

Submitter Checklist:

• I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
• There is a ticket for my issue
• Used Github auto-closing keywords in the PR description above
• Wrote a good PR/commit description
• Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
• Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
• Checked the PR locally:
  • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
  • npm run presubmit wiki, npm run gn_check, npm run tslint
• Ran git rebase master (if needed)

Reviewer Checklist:

• A security review is not needed, or a link to one is included in the PR description
• New files have MPL-2.0 license header
• Adequate test coverage exists to prevent regressions
• Major classes, functions and non-trivial code blocks are well-commented
• Changes in component dependencies are properly reflected in gn
• Code follows the style guide
• Test plan is specified in PR before merging

After-merge Checklist:

• The associated issue milestone is set to the smallest version that the
  changes has landed on
• All relevant documentation has been updated, for instance:
  • https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
  • https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
  • https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections
  • https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
  • https://github.com/brave/brave-browser/wiki/Web-Compatibility-Exceptions-in-Brave
  • https://github.com/brave/brave-browser/wiki/QA-Guide
  • https://github.com/brave/brave-browser/wiki/P3A

Test Plan:

1. Run brave with clean profile and apply adb shell "echo ' --enable-features=NewAndroidOnboarding' > /data/local/tmp/brave-test-day-zero-expt"
2. launch the app
3. observer the onboarding
4. it should behave as show below in the recording.

VIDEO coming soon

[samartnik]

lgtm

[mherrmann]

Do we also need changes an about_flags.cc, as in f49e3df#diff-cacbc437964cc20aaaf741b80ecbea5cfce9ca9e67725476f73f14cbab2269fb ?

[deeppandya]

Do we also need changes an about_flags.cc, as in f49e3df#diff-cacbc437964cc20aaaf741b80ecbea5cfce9ca9e67725476f73f14cbab2269fb ?

@mherrmann i don't think we need to expose the flag for users as we can control it through griffin.

[DJAndries]

lgtm

[brave-builds]

Released in v1.75.110

[kjozwiak]

Verification PASSED on Pixel 6 running Android 15 using the following build(s):

Brave | 1.75.110 Chromium: 132.0.6834.46 (Official Build) canary (64-bit)
--- | ---
Revision | ba1e1f0bda21276e78426fcbf9ab0a82d0c3d799
OS | Android 15; Build/AP41.240925.012; 35; REL

• installed 1.75.110 Chromium: 132.0.6834.46
• before launching the browser, connected to Linux VM, ran through the following commands via the terminal

kjozwiak@kjozwiak-VMUbuntu:~$ adb shell "echo ' --enable-features=NewAndroidOnboarding' > /data/local/tmp/brave-test-day-zero-expt"
kjozwiak@kjozwiak-VMUbuntu:~$ adb shell "cat /data/local/tmp/brave-test-day-zero-expt"
 --enable-features=NewAndroidOnboarding
kjozwiak@kjozwiak-VMUbuntu:~$

• ensured that the new onboarding is being used that was implemented/tested (11% retention increase)
• Improve Android first run experience for better retention #25696
• ensured that there's no Notification system permission modal when Brave first launches
• ensured that the default browser system modal appears
• ensured that the P3A/Data onboarding card is still being displayed

screen-20241218-204843.mp4

Also ensured the following so we don't run into issues like brave/brave-browser#42113 & brave/brave-browser#42120:

• ensured that SNTP are being displayed/appearing without any issues
• ensured that Rewards icon is still being displayed and the user can opt-in into rewards
• ensured that Brave News opt-in card is being displayed via NTP
• ensured that Brave Wallet appears within the Hamburger Menu and is selectable/working without any issues

Example	Example	Example	Example

Ensured that once adb shell "rm /data/local/tmp/brave-test-day-zero-expt", the old onboarding is being launched/working as per the following:

screen-20241218-214135.mp4