Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Update onboarding with new flag #42863

Closed
deeppandya opened this issue Dec 12, 2024 · 2 comments · Fixed by brave/brave-core#26999
Closed

[Android] Update onboarding with new flag #42863

deeppandya opened this issue Dec 12, 2024 · 2 comments · Fixed by brave/brave-core#26999

Comments

@deeppandya
Copy link

As a follow up to day zero A/B testing with new onboarding changes,
In this issue we need to remove the changes for onboarding which was relying on day zero flag and update onboarding changes to use new flag NewAndroidOnboarding flag.

We also removed the study for day zero flag here : brave/brave-variations#1279
We have a new study with a new flag NewAndroidOnboarding here : brave/brave-variations#1282

@kjozwiak
Copy link
Member

The above requires 1.73.104 or higher for 1.73.x verification 👍 @Uni-verse @hffvld can use brave/brave-core#26999 (comment) as a template for 1.73.x verification.

@Uni-verse
Copy link
Contributor

Uni-verse commented Dec 19, 2024

Verified on Samsung Galaxy S21 & Samsung Galaxy Tab S7 using version:

Brave	1.73.104 Chromium: 131.0.6778.204 (Official Build) (64-bit) 
Revision	215b794a7c1f3e28151d0f7712e32c71be48775c
OS	Android 13; Build/TP1A.220624.014; 33; REL
  • Enabled the following flag using CLI before launching Brave:

Image

  • Ensured that the new onboarding is being used.
  • Ensured that there's no Notification system permission modal when Brave first launches
  • Ensured that the default browser system modal appears
  • Ensured that the P3A/Data onboarding card is still being displayed

Also ensured the following:

  • Ensured that SINTP are being displayed/appearing without any issues
  • Ensured that Rewards icon is still being displayed and the user can opt-in into rewards
  • Ensured that Brave News opt-in card is being displayed via NTP
  • Ensured that Brave Wallet appears within the Hamburger Menu and is selectable/working without any issues
  • Ensured that once adb shell "rm /data/local/tmp/brave-test-day-zero-expt", the old onboarding is being launched/working as per the following:
example example example example example
Image Image Image Image Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants