Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New onboarding changes android [Uplift to 1.74.x] #27058

Merged
merged 1 commit into from
Dec 19, 2024
Merged

New onboarding changes android [Uplift to 1.74.x] #27058

merged 1 commit into from
Dec 19, 2024
+23 −6

Conversation

deeppandya
Copy link
Contributor

@deeppandya deeppandya commented Dec 18, 2024 •
edited by kjozwiak
Loading

Uplift of #26999
Resolves brave/brave-browser#42863

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@deeppandya deeppandya added this to the 1.74.x - Beta milestone Dec 18, 2024
@deeppandya deeppandya self-assigned this Dec 18, 2024
@deeppandya deeppandya requested a review from a team as a code owner December 18, 2024 16:59
@deeppandya
Merge pull request #26999 from brave/new_onboarding_changes_android
302fc27 
New onboarding changes android

Resolve rebase issue
@deeppandya deeppandya force-pushed the new_onboarding_changes_android_1.74.x branch from f3dde25 to 302fc27 Compare December 18, 2024 20:57
kjozwiak
kjozwiak approved these changes Dec 19, 2024
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.74.x approved 👍 QA has verified the PR on Nightly using 1.75.x as per #26999 (comment).

@kjozwiak kjozwiak merged commit 4ef181e into 1.74.x Dec 19, 2024
16 checks passed
@kjozwiak kjozwiak deleted the new_onboarding_changes_android_1.74.x branch December 19, 2024 02:46
@brave-builds
Copy link
Collaborator

Released in v1.74.31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@deeppandya deeppandya

Labels
None yet
Projects
None yet
Milestone
1.74.x - Beta
Development

Successfully merging this pull request may close these issues.
3 participants
@deeppandya @brave-builds @kjozwiak