Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add android onboarding study #1282

Merged
merged 3 commits into from
Dec 23, 2024
Merged

Add android onboarding study #1282

merged 3 commits into from
Dec 23, 2024

Conversation

deeppandya
Copy link
Contributor

Resolves : #1281

@deeppandya deeppandya self-assigned this Dec 12, 2024
@deeppandya deeppandya requested a review from a team as a code owner December 12, 2024 16:03
Copy link
Contributor

github-actions bot commented Dec 12, 2024

✅ Test Seed Generated Successfully

To apply the test seed:

  1. Desktop: Launch the browser with --variations-pr=1282.
    Android: Set the command line to --variations-pr=1282 in debug menu, restart the browser.
    iOS: Set Variations PR to 1282 in Brave Core Switches debug menu, restart the browser.
  2. Wait 5-10 seconds to fetch the seed.
  3. Restart the browser to apply the seed.
  4. Ensure Active Variations section at brave://version starts with the expected seed version (see below).

Seed Details

Parameter Value
Version pull/1282@2912c808f093ec8f393a955d414b3299006a6c50
Uploaded Tue, 17 Dec 2024 16:47:52 GMT
PR commit 4a99a1d
Base commit 7970395
Merge commit 2912c80
Serial number d32b35cf61c733c594663074b0fd0edc

@deeppandya deeppandya force-pushed the add_android_onboarding_study branch from b043ab6 to 4ad7970 Compare December 12, 2024 17:29
@kjozwiak
Copy link
Member

Blocked till brave/brave-core#26999 is merged into master and uplifted/released via 1.73.x. Once the new flag is pushed and 1.73.x is set at 100%, we'll push the above. We're also changing the above via:

  • Nightly & BETA will be set at 100% form the start
  • Release will start at 25% as discussed on Slack

CCing @timchilds

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into main/production approved after deliberating with @brave/uplift-approvers.

@kjozwiak kjozwiak added this pull request to the merge queue Dec 23, 2024
Merged via the queue into main with commit f7d4027 Dec 23, 2024
6 checks passed
@kjozwiak kjozwiak deleted the add_android_onboarding_study branch December 23, 2024 17:50
@kjozwiak
Copy link
Member

Verification PASSED on Pixel 6 running Android 15 using the following build(s):

Nightly - AndroidOnboardingStudy:Enabled

Brave | 1.75.118 Chromium: 132.0.6834.57 (Official Build) canary (64-bit)
--- | ---
Revision | 7ad77ca4173af4e4eed04688bdb2f8752acd6800
OS | Android 15; Build/BP11.241121.010; 35; REL
  • installed/launched 1.75.118 Chromium: 132.0.6834.57
  • ensured that the new onboarding is being used re: the system modal appearing right after the Brave animation re: setting Brave as the default browser
  • ensured that AndroidOnboardingStudy:Enabled via brave://version
screen-20241223-130551.mp4

BETA - AndroidOnboardingStudy:Enabled

Brave | 1.74.33 Chromium: 132.0.6834.57 (Official Build) beta (64-bit)
--- | ---
Revision | 7c275fd7e15fff5e960f2505bc49639361866c5b
OS | Android 15; Build/BP11.241121.010; 35; REL
  • installed/launched 1.74.33 Chromium: 132.0.6834.57
  • ensured that the new onboarding is being used re: the system modal appearing right after the Brave animation re: setting Brave as the default browser
  • ensured that AndroidOnboardingStudy:Enabled via brave://version
screen-20241223-131649.mp4

Release - AndroidOnboardingStudy:Default

Brave | 1.73.104 Chromium: 131.0.6778.204 (Official Build) (64-bit)
--- | ---
Revision | 215b794a7c1f3e28151d0f7712e32c71be48775c
OS | Android 15; Build/BP11.241121.010; 35; REL
  • installed/launched 1.73.104 Chromium: 131.0.6778.204 via GPS
  • ensured that the previous onboarding is being used:
    • system notification permission modal
    • onboarding modeal which requires selecting "Make Default" before receiving the system default modal
    • P3A modal
  • ensured that AndroidOnboardingStudy:Default via brave://version
screen-20241223-133252.mp4

Release - AndroidOnboardingStudy:Enabled

Brave | 1.73.104 Chromium: 131.0.6778.204 (Official Build) (64-bit)
--- | ---
Revision | 215b794a7c1f3e28151d0f7712e32c71be48775c
OS | Android 15; Build/BP11.241121.010; 35; REL
  • installed/launched 1.73.104 Chromium: 131.0.6778.204 via GPS
  • ensured that the new onboarding is being used re: the system modal appearing right after the Brave animation re: setting Brave as the default browser
  • ensured that AndroidOnboardingStudy:Enabled via brave://version
screen-20241223-134452.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add android onboarding study
2 participants