chore: remove v1 rrweb loading #1078
Conversation
|
Size Change: +87.7 kB (+10%) Total Size: 940 kB
ℹ️ View Unchanged
|
rollup.config.js
Outdated
| @@ -22,18 +22,6 @@ const plugins = [ | |||
|
|
|||
| /** @type {import('rollup').RollupOptions[]} */ | |||
| export default [ | |||
| { | |||
| input: 'src/loader-recorder.ts', | |||
There was a problem hiding this comment.
Whoops! We can't do this. Any old versions depending on it will break...
There was a problem hiding this comment.
I'd recommend just creating the old and new file both as the rrweb v2.
There was a problem hiding this comment.
Do you mean to point dist/recorder.js at src/loader-recorder-v2.ts (as in 818d433)
Or do some people reference src/loader-recorder.ts in their implementation?
There was a problem hiding this comment.
As in older versions will still load recorder.js or recorder-v2.js so we can't get rid of either file for backwards compatability.
There was a problem hiding this comment.
Pushed a commit to update what I meant
|
Holding off shipping until tomorrow morning so there is a full day in case this causes any unexpected customer issues |
Changes
Checklist