Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update default rrweb in array.full.js #1077

Closed
wants to merge 1 commit into from

Conversation

daibhin
Copy link
Contributor

@daibhin daibhin commented Mar 13, 2024

Changes

Default to using rrweb v2 in the array.full.js

Following up with a change to remove v1 entirely, but this we certainly want to do.

Checklist

  • Tests for new code (see advice on the tests we use)
  • Accounted for the impact of any changes across different browsers
  • Accounted for backwards compatibility of any changes (no breaking changes in posthog-js!)

@daibhin daibhin requested a review from a team March 13, 2024 15:59
Copy link

Size Change: +41.7 kB (+5%) 🔍

Total Size: 894 kB

Filename Size Change
dist/array.full.js 224 kB +41.7 kB (+23%) 🚨
ℹ️ View Unchanged
Filename Size
dist/array.js 124 kB
dist/es.js 124 kB
dist/exception-autocapture.js 12.1 kB
dist/module.js 124 kB
dist/recorder-v2.js 106 kB
dist/recorder.js 58.7 kB
dist/surveys-module-previews.js 62 kB
dist/surveys.js 58.3 kB

compressed-size-action

@marandaneto
Copy link
Member

+41.7 kB

@daibhin is the rrweb v2 smaller than v1?
if so, it might make sense to stack PRs on each other, otherwise, this version will increase by quite a bit already but not benefit the other gains.

@daibhin daibhin changed the title update default rrweb in array.full.js chore: update default rrweb in array.full.js Mar 13, 2024
@daibhin
Copy link
Contributor Author

daibhin commented Mar 13, 2024

@marandaneto we'll find out in #1078. My guess is that we should ship this regardless because including rrweb v1 in array.full.js is technically a bug because I'm not sure we even support it anymore

Copy link
Member

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't run it locally... let's make sure we do before we ship it... (i think maybe cypress tests run session replay from array full)

I'd guess the bundle increase is that we'll only now be including network capture in the array full bundle

@daibhin
Copy link
Contributor Author

daibhin commented Mar 14, 2024

Closing in favour of #1078

@daibhin daibhin closed this Mar 14, 2024
@daibhin daibhin deleted the dn-chore/update-default-rrweb branch March 14, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants