-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Remove v2 rrweb checks #1080
Conversation
Size Change: -807 B (0%) Total Size: 940 kB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good whenever the other PR is merged and the CDN is ready. How long would you expect the cache to take?
It should be a five minute cache. You can check the headers on the JS response. I guess maybe we'd need to check multiple URLs at the moment 🤷 |
Confirmed that https://internal-e.posthog.com/static/recorder.js now contains the v2 config:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
feels like a monday morning rather than a friday afternoon change 🙈 but don't let me block
Happy to merge this one now @benjackwhite? |
Changes
Follow up after #1078 is fully released
Checklist