chore: remove v1 rrweb loading (#1078)

cypress/support/e2e.ts

@@ -24,6 +24,7 @@ beforeEach(() => {
 
     cy.readFile('dist/recorder.js').then((body) => {
         cy.intercept('**/static/recorder.js*', { body }).as('recorder')
+        cy.intercept('**/static/recorder-v2.js*', { body }).as('recorder')
     })
 
     cy.readFile('dist/surveys.js').then((body) => {

package.json

@@ -88,7 +88,6 @@
         "rollup-plugin-visualizer": "^5.12.0",
         "rrweb": "2.0.0-alpha.11",
         "rrweb-snapshot": "2.0.0-alpha.11",
-        "rrweb-v1": "npm:[email protected]",
         "sinon": "9.0.2",
         "testcafe": "1.19.0",
         "testcafe-browser-provider-browserstack": "1.14.0",

rollup.config.js

@@ -31,13 +31,8 @@ export default [
                 format: 'iife',
                 name: 'posthog',
             },
-        ],
-        plugins: [...plugins],
-    },
-    {
-        input: 'src/loader-recorder-v2.ts',
-        output: [
             {
+                // Backwards compatibility for older SDK versions
                 file: 'dist/recorder-v2.js',
                 sourcemap: true,
                 format: 'iife',

src/__tests__/extensions/replay/sessionrecording.test.ts

@@ -7,7 +7,6 @@ import {
     SESSION_RECORDING_CANVAS_RECORDING,
     SESSION_RECORDING_ENABLED_SERVER_SIDE,
     SESSION_RECORDING_IS_SAMPLED,
-    SESSION_RECORDING_RECORDER_VERSION_SERVER_SIDE,
 } from '../../../constants'
 import { SessionIdManager } from '../../../sessionid'
 import {
@@ -151,7 +150,6 @@ describe('SessionRecording', () => {
         // defaults
         posthog.persistence?.register({
             [SESSION_RECORDING_ENABLED_SERVER_SIDE]: true,
-            [SESSION_RECORDING_RECORDER_VERSION_SERVER_SIDE]: 'v2',
             [CONSOLE_LOG_RECORDING_ENABLED_SERVER_SIDE]: false,
             [SESSION_RECORDING_IS_SAMPLED]: undefined,
         })
@@ -203,33 +201,6 @@ describe('SessionRecording', () => {
         })
     })
 
-    describe('getRecordingVersion', () => {
-        it('uses client side setting v2 over server side', () => {
-            posthog.persistence?.register({ [SESSION_RECORDING_RECORDER_VERSION_SERVER_SIDE]: 'v1' })
-            posthog.config.session_recording.recorderVersion = 'v2'
-            expect(sessionRecording['recordingVersion']).toBe('v2')
-        })
-
-        it('uses client side setting v1 over server side', () => {
-            posthog.persistence?.register({ [SESSION_RECORDING_RECORDER_VERSION_SERVER_SIDE]: 'v2' })
-            posthog.config.session_recording.recorderVersion = 'v1'
-            expect(sessionRecording['recordingVersion']).toBe('v1')
-        })
-
-        it('uses server side setting if client side setting is not set', () => {
-            posthog.config.session_recording.recorderVersion = undefined
-
-            posthog.persistence?.register({ [SESSION_RECORDING_RECORDER_VERSION_SERVER_SIDE]: 'v1' })
-            expect(sessionRecording['recordingVersion']).toBe('v1')
-
-            posthog.persistence?.register({ [SESSION_RECORDING_RECORDER_VERSION_SERVER_SIDE]: 'v2' })
-            expect(sessionRecording['recordingVersion']).toBe('v2')
-
-            posthog.persistence?.register({ [SESSION_RECORDING_RECORDER_VERSION_SERVER_SIDE]: undefined })
-            expect(sessionRecording['recordingVersion']).toBe('v1')
-        })
-    })
-
     describe('startRecordingIfEnabled', () => {
         beforeEach(() => {
             // need to cast as any to mock private methods
@@ -729,16 +700,7 @@ describe('SessionRecording', () => {
             expect(loadScript).not.toHaveBeenCalled()
         })
 
-        it('loads recording v1 script from right place', () => {
-            posthog.config.session_recording.recorderVersion = 'v1'
-
-            sessionRecording.startRecordingIfEnabled()
-
-            expect(loadScript).toHaveBeenCalledWith('https://test.com/static/recorder.js?v=v0.0.1', expect.anything())
-        })
-
         it('loads recording v2 script from right place', () => {
-            posthog.persistence?.register({ [SESSION_RECORDING_RECORDER_VERSION_SERVER_SIDE]: 'v2' })
             sessionRecording.startRecordingIfEnabled()
 
             expect(loadScript).toHaveBeenCalledWith(
@@ -749,7 +711,6 @@ describe('SessionRecording', () => {
 
         it('load correct recording version if there is a cached mismatch', () => {
             posthog.__loaded_recorder_version = 'v1'
-            posthog.persistence?.register({ [SESSION_RECORDING_RECORDER_VERSION_SERVER_SIDE]: 'v2' })
             sessionRecording.startRecordingIfEnabled()
 
             expect(loadScript).toHaveBeenCalledWith(

src/constants.ts

@@ -13,7 +13,6 @@ export const EVENT_TIMERS_KEY = '__timers'
 export const AUTOCAPTURE_DISABLED_SERVER_SIDE = '$autocapture_disabled_server_side'
 export const SESSION_RECORDING_ENABLED_SERVER_SIDE = '$session_recording_enabled_server_side'
 export const CONSOLE_LOG_RECORDING_ENABLED_SERVER_SIDE = '$console_log_recording_enabled_server_side'
-export const SESSION_RECORDING_RECORDER_VERSION_SERVER_SIDE = '$session_recording_recorder_version_server_side' // follows rrweb versioning
 export const SESSION_RECORDING_NETWORK_PAYLOAD_CAPTURE = '$session_recording_network_payload_capture'
 export const SESSION_RECORDING_CANVAS_RECORDING = '$session_recording_canvas_recording'
 export const SESSION_ID = '$sesid'

src/extensions/replay/sessionrecording.ts

@@ -4,7 +4,6 @@ import {
     SESSION_RECORDING_ENABLED_SERVER_SIDE,
     SESSION_RECORDING_IS_SAMPLED,
     SESSION_RECORDING_NETWORK_PAYLOAD_CAPTURE,
-    SESSION_RECORDING_RECORDER_VERSION_SERVER_SIDE,
 } from '../../constants'
 import {
     FULL_SNAPSHOT_EVENT_TYPE,
@@ -196,12 +195,6 @@ export class SessionRecording {
             : undefined
     }
 
-    private get recordingVersion() {
-        const recordingVersion_server_side = this.instance.get_property(SESSION_RECORDING_RECORDER_VERSION_SERVER_SIDE)
-        const recordingVersion_client_side = this.instance.config.session_recording?.recorderVersion
-        return recordingVersion_client_side || recordingVersion_server_side || 'v1'
-    }
-
     // network payload capture config has three parts
     // each can be configured server side or client side
     private get networkPayloadCapture():
@@ -345,7 +338,6 @@ export class SessionRecording {
             this.instance.persistence.register({
                 [SESSION_RECORDING_ENABLED_SERVER_SIDE]: !!response['sessionRecording'],
                 [CONSOLE_LOG_RECORDING_ENABLED_SERVER_SIDE]: response.sessionRecording?.consoleLogRecordingEnabled,
-                [SESSION_RECORDING_RECORDER_VERSION_SERVER_SIDE]: response.sessionRecording?.recorderVersion,
                 [SESSION_RECORDING_NETWORK_PAYLOAD_CAPTURE]: {
                     capturePerformance: response.capturePerformance,
                     ...response.sessionRecording?.networkPayloadCapture,
@@ -433,17 +425,15 @@ export class SessionRecording {
         // We want to ensure the sessionManager is reset if necessary on load of the recorder
         this.sessionManager.checkAndGetSessionAndWindowId()
 
-        const recorderJS = this.recordingVersion === 'v2' ? 'recorder-v2.js' : 'recorder.js'
-
         // If recorder.js is already loaded (if array.full.js snippet is used or posthog-js/dist/recorder is
         // imported) or matches the requested recorder version, don't load script. Otherwise, remotely import
         // recorder.js from cdn since it hasn't been loaded.
-        if (this.instance.__loaded_recorder_version !== this.recordingVersion) {
+        if (this.instance.__loaded_recorder_version !== 'v2') {
             loadScript(
-                this.instance.requestRouter.endpointFor('assets', `/static/${recorderJS}?v=${Config.LIB_VERSION}`),
+                this.instance.requestRouter.endpointFor('assets', `/static/recorder-v2.js?v=${Config.LIB_VERSION}`),
                 (err) => {
                     if (err) {
-                        return logger.error(LOGGER_PREFIX + ` could not load ${recorderJS}`, err)
+                        return logger.error(LOGGER_PREFIX + ` could not load recorder-v2.js`, err)
                     }
 
                     this._onScriptLoaded()