feature(onboarding): combine category and tag setup task for connections #51926

jaydamani · 2024-11-02T12:27:51Z

Explanation of Change

Show combined task for tags and categories setup if the user selects an accounting integration

Fixed Issues

$ #51591
PROPOSAL: #51591 (comment)

Tests

Sign up with a new account
In onboarding popup, select "Managing my team's expenses"
Complete onboarding by answering the remaining questions
Go to concierge chat
Verify there is a task for "Setup Categories and Tags"
Open the "Setup Categories and Tags" task

Verify that no errors appear in the JS console

Offline tests

Sign up with a new account
In onboarding popup, select "Managing my team's expenses"
Complete onboarding by answering the remaining questions
Go to concierge chat
Verify there is a task for "Setup Categories and Tags"
Open the "Setup Categories and Tags" task

QA Steps

Sign up with a new account
In onboarding popup, select "Managing my team's expenses"
Complete onboarding by answering the remaining questions
Go to concierge chat
Verify there is a task for "Setup Categories and Tags"
Open the "Setup Categories and Tags" task

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android-app.mp4

Android: mWeb Chrome

android-web.mp4

iOS: Native

IOS-app.mp4

iOS: mWeb Safari

IOS-web.mp4

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

jaydamani · 2024-11-02T12:52:38Z

@marcaaron a new task type called 'setupCategoriesAndTags' needs to be added in back-end, tested my changes locally by using addAccountingIntegration as task type

Also, please confirm if the links in task description are correct,

connecting your accounting software will take user to Accountings page in workspace settings
workspace settings will take user to the Categories page in workspace settings because in this context, categories seems more relevant than the first page in workspace settings but this task is also for tags so I am unsure about this.

Will complete checklist with end to end testing in all platforms once the back-end change is done.
CC: @dukenv0307

marcaaron · 2024-11-04T19:09:16Z

workspace settings will take user to the Categories page in workspace settings because in this context, categories seems more relevant than the first page in workspace settings but this task is also for tags so I am unsure about this.

I'm not so sure about this part. Can you ask this question on the original issue and tag in the issue creator please?

'setupCategoriesAndTags' needs to be added in back-end

I will raise a PR to do this today.

marcaaron · 2024-11-04T19:28:17Z

categories seems more relevant than the first page in workspace settings

Since it's "categories" AND "tags" - I think what you are saying is incorrect. The user could set up categories or tags. So, probably we just want the workspace settings...

jaydamani · 2024-11-05T19:03:50Z

I'm not so sure about this part. Can you ask this question on the original issue and tag in the issue creator please?

Asked here

Since it's "categories" AND "tags" - I think what you are saying is incorrect. The user could set up categories or tags. So, probably we just want the workspace settings...

Updated to use settings link

marcaaron · 2024-11-12T20:31:27Z

We should be able to proceed here now as the backend change was deployed.

jaydamani · 2024-11-13T03:44:49Z

We should be able to proceed here now as the backend change was deployed.

Couldn't work on it yesterday, I will start making the changes today

melvin-bot · 2024-11-13T23:30:11Z

@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dukenv0307 · 2024-11-14T04:37:56Z

@jaydamani Tests are failed

jaydamani · 2024-11-14T05:00:44Z

@dukenv0307 The error is coming from a file that was not updated in PR so, not sure what is the issue. Will try to merge with main again after some time and hopefully that should resolve it.

jaydamani · 2024-11-14T15:43:35Z

@dukenv0307 it is fixed now, please review

dukenv0307 · 2024-11-15T03:27:26Z

src/libs/actions/Report.ts

@@ -3529,6 +3533,7 @@ function prepareOnboardingOptimisticData(
                          navatticURL: getNavatticURL(environment, engagementChoice),
                          integrationName,
                          workspaceAccountingLink: `${environmentURL}/${ROUTES.POLICY_ACCOUNTING.getRoute(onboardingPolicyID ?? '-1')}`,
+                          workspaceSettingsLink: `${environmentURL}/${ROUTES.WORKSPACE_INITIAL.getRoute(onboardingPolicyID ?? '01')}`,


Suggested change

workspaceSettingsLink: `${environmentURL}/${ROUTES.WORKSPACE_INITIAL.getRoute(onboardingPolicyID ?? '01')}`,

workspaceSettingsLink: `${environmentURL}/${ROUTES.WORKSPACE_INITIAL.getRoute(onboardingPolicyID ?? '-1')}`,

dukenv0307 · 2024-11-15T04:08:08Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-11-15.at.10.53.29.mov

Android: mWeb Chrome

mandroid-resize.mp4

iOS: Native

Screen.Recording.2024-11-15.at.10.52.55.mov

iOS: mWeb Safari

Screen.Recording.2024-11-15.at.10.48.09.mov

MacOS: Chrome / Safari

Manage team members with accounting integration

Screen.Recording.2024-11-15.at.10.40.24.mov

Manage team members without accounting integration

Screen.Recording.2024-11-15.at.10.42.43.mov

Normal flow

Screen.Recording.2024-11-15.at.10.43.17.mov

MacOS: Desktop

Screen.Recording.2024-11-15.at.10.58.43.mov

dukenv0307 · 2024-11-15T04:08:51Z

@jaydamani I left one minor comment, the rest looks good

OSBotify · 2024-11-15T22:22:10Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-11-19T01:22:02Z

🚀 Deployed to staging by https://github.com/marcaaron in version: 9.0.64-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

github-actions · 2024-11-21T01:15:59Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 9.0.64-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

jaydamani added 2 commits November 2, 2024 13:23

feature(onboarding): combine category and tag setup task for connections

936b5bd

update task type

3c8de6d

jaydamani mentioned this pull request Nov 2, 2024

[HOLD for payment 2024-11-28] [$250] Combine the Category and Tag Tasks when direct accounting selection in the onboarding intent #51591

Closed

update link in setupCategoriesAndTags

766e05b

Merge branch 'main' into onboaring/combine-category-and-tag-task--51591

b1534bf

marcaaron assigned jaydamani Nov 13, 2024

jaydamani marked this pull request as ready for review November 13, 2024 23:30

jaydamani requested a review from a team as a code owner November 13, 2024 23:30

melvin-bot bot requested review from dukenv0307 and removed request for a team November 13, 2024 23:30

Merge branch 'main' into onboaring/combine-category-and-tag-task--51591

ddf0189

dukenv0307 reviewed Nov 15, 2024

View reviewed changes

fix default for id

6dc5507

marcaaron approved these changes Nov 15, 2024

View reviewed changes

marcaaron merged commit 99bf554 into Expensify:main Nov 15, 2024
16 checks passed

github-actions bot mentioned this pull request Nov 19, 2024

Deploy Checklist: New Expensify 2024-11-19 #52733

Closed

54 tasks

grgia mentioned this pull request Nov 19, 2024

Concierge - Set up categories and tags task is not auto-completed when set both #52755

Closed

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feature(onboarding): combine category and tag setup task for connections #51926

feature(onboarding): combine category and tag setup task for connections #51926

jaydamani commented Nov 2, 2024 •

edited

Loading

jaydamani commented Nov 2, 2024

marcaaron commented Nov 4, 2024

marcaaron commented Nov 4, 2024

jaydamani commented Nov 5, 2024

marcaaron commented Nov 12, 2024

jaydamani commented Nov 13, 2024

melvin-bot bot commented Nov 13, 2024

dukenv0307 commented Nov 14, 2024

jaydamani commented Nov 14, 2024

jaydamani commented Nov 14, 2024

dukenv0307 Nov 15, 2024

dukenv0307 commented Nov 15, 2024

dukenv0307 commented Nov 15, 2024

OSBotify commented Nov 15, 2024

github-actions bot commented Nov 19, 2024

github-actions bot commented Nov 21, 2024

	workspaceSettingsLink: `${environmentURL}/${ROUTES.WORKSPACE_INITIAL.getRoute(onboardingPolicyID ?? '01')}`,
	workspaceSettingsLink: `${environmentURL}/${ROUTES.WORKSPACE_INITIAL.getRoute(onboardingPolicyID ?? '-1')}`,

feature(onboarding): combine category and tag setup task for connections #51926

feature(onboarding): combine category and tag setup task for connections #51926

Conversation

jaydamani commented Nov 2, 2024 • edited Loading

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

jaydamani commented Nov 2, 2024

marcaaron commented Nov 4, 2024

marcaaron commented Nov 4, 2024

jaydamani commented Nov 5, 2024

marcaaron commented Nov 12, 2024

jaydamani commented Nov 13, 2024

melvin-bot bot commented Nov 13, 2024

dukenv0307 commented Nov 14, 2024

jaydamani commented Nov 14, 2024

jaydamani commented Nov 14, 2024

dukenv0307 Nov 15, 2024

Choose a reason for hiding this comment

dukenv0307 commented Nov 15, 2024

Reviewer Checklist

Screenshots/Videos

dukenv0307 commented Nov 15, 2024

OSBotify commented Nov 15, 2024

github-actions bot commented Nov 19, 2024

github-actions bot commented Nov 21, 2024

jaydamani commented Nov 2, 2024 •

edited

Loading