[HOLD for payment 2024-11-28] [$250] Combine the Category and Tag Tasks when direct accounting selection in the onboarding intent

[davidcardoza]

Problem

During onboarding, users who select a direct accounting integration (such as QuickBooks Online) are presented with separate tasks to set up "Categories" and "Tags." However, because both categories and tags are automatically managed by the direct accounting integration, these setup tasks are redundant and can be confusing for users who don’t need to take any additional steps.

Solution

Combine the Category and Tag Setup Tasks: When a user selects a direct accounting connection like QBO, the tasks for "Setup Categories" and "Setup Tags" should be combined into a single, streamlined task that reflects their automatic setup via the integration.

• Slack conversation for additional background - https://expensify.slack.com/archives/C07HPDRELLD/p1729708260070999
• Related GH - [HOLD for payment 2024-11-13] [HOLD for payment 2024-10-22] [$250] Ask our admin leads qualifying questions in Stage 1 and trigger "set up accounting integration" task #48745

Issue Owner

Current Issue Owner: @

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021862321644417750071
• Upwork Job ID: 1862321644417750071
• Last Price Increase: 2024-11-29

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @dukenv0307 (External)

[jaydamani]

Edited by proposal-police: This proposal was edited at 2024-10-28 18:54:41 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Remove Category and Tag Tasks when direct accounting selection in the onboarding intent

What is the root cause of that problem?

Enhancement

What changes do you think we should make in order to solve the problem?

The default tasks come from here and are created here

We can hide the tasks based on if the user selects an integration or not. To implemt this, we can update here to filter out the tasks using below logic where, we show a new "set up categories and tags" task if a connection was selected. If no connection was selected then we show separate tasks for "set up categories" and "setup tags" like we show currently.

const filteredTasks = data.tasks.filter(task => userReportedIntegration 
	? task.type != 'setupCategories' && task.type != 'setupTags'
	: task.type != 'setupTagsAndCategoriesForConnections')
const tasksData = filteredTasks.map((task, index) => {
    ...
}

The new task will be added here.

	...
	tasks: [
		...
		{
			type: 'setupTagsAndCategoriesForConnections',
			autoCompleted: false,
			title: 'Set up tags & categories',
			description: 'Your categories and tags are automatically created based on the selected connection.'
		}
		...
	]
	...

Note: This code is just for explaination purposes. Code quality can be improved during PR.

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[Shahidullah-Muffakir]

Proposal

Please re-state the problem that we are trying to solve in this issue.

During onboarding, if a user selects an accounting integration (like QuickBooks Online), they still see tasks to Set up categories and Set up tags. Since these elements are automatically managed by the integration, showing these tasks is redundant.

What is the root cause of that problem?

The current onboarding logic assigns a set of default tasks (including Set up categories and Set up tags) when CONST.ONBOARDING_CHOICES.MANAGE_TEAM is selected. Among these, only Create workspace is set to autoComplete by default.

App/src/CONST.ts

Lines 4734 to 4736 in 8ef040a

	type: 'createWorkspace',
	autoCompleted: true,
	title: 'Create a workspace',

What changes do you think we should make in order to solve the problem?

We can update the completeOnboarding to exclude Set up categories and Set up tags if the user has selected a direct accounting integration in onboarding. This would treat those tasks as complete by default.

Change this line:

App/src/libs/actions/Report.ts

Line 3435 in 8ef040a

const completedTaskReportAction = task.autoCompleted

to this:

const completedTaskReportAction = (task.autoCompleted || (userReportedIntegration && (task.type === 'setupCategories' || task.type === 'setupTags')));

Screen.20Recording.202024-10-29.20at.204.mp4

[NJ-2020]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Remove Category and Tag Tasks when direct accounting selection in the onboarding intent

What is the root cause of that problem?

Enhancement

What changes do you think we should make in order to solve the problem?

We should remove the tags and categories here

App/src/CONST.ts

Lines 4756 to 4778 in db592c9

	{
	type: 'setupCategories',
	autoCompleted: false,
	title: 'Set up categories',
	description: ({workspaceCategoriesLink}) =>
	'*Set up categories* so your team can code expenses for easy reporting.\n' +
	'\n' +
	'Here’s how to set up categories:\n' +
	'\n' +
	'1. Click your profile picture.\n' +
	'2. Go to *Workspaces*.\n' +
	'3. Select your workspace.\n' +
	'4. Click *Categories*.\n' +
	'5. Add or import your own categories.\n' +
	"6. Disable any default categories you don't need.\n" +
	'7. Require a category for every expense in *Settings*.\n' +
	'\n' +
	`[Take me to workspace category settings](${workspaceCategoriesLink}).`,
	},
	{
	type: 'setupTags',
	autoCompleted: false,
	title: 'Set up tags',

What alternative solutions did you explore? (Optional)

We will exclude the tasksData if the type is setupCategories or setupTags

App/src/libs/actions/Report.ts

Lines 3403 to 3404 in db592c9

	const tasksData = data.tasks.map((task, index) => {

const excludeTasksData = ["setupCategories", "setupTags"]
const filteredTasksData = data.tasks.filter((task) => !excludeTasksData.includes(task.type))
const tasksData = filteredTasksData.map((task, index) => {

Result

Screen.Recording.2024-10-28.at.22.11.11.mov

[nkdengineer]

@davidcardoza I can take this one since it's related to #48745 (comment)

[dukenv0307]

@nkdengineer What do you mean? Is it your regression?

[nkdengineer]

@nkdengineer What do you mean? Is it your regression?

@dukenv0307 It's not my regressions. It's related to the new feature that I'm working on here so I have more context on this and I'd like to work here.

[dukenv0307]

@jaydamani

const tasksData = data.tasks.filter(task => userReportedIntegration && (task.type == 'setupCategories' || task.type == 'setupTags')).map((task, index) => {

I understand your mean here is to filter out setupCategories and setupTags if users select the accounting connection. If so, the updated code should be:

    const tasksData = data.tasks.filter(task => !userReportedIntegration || (task.type != 'setupCategories' && task.type != 'setupTags')).map((task, index) => {

Is it correct?

[jaydamani]

@jaydamani

const tasksData = data.tasks.filter(task => userReportedIntegration && (task.type == 'setupCategories' || task.type == 'setupTags')).map((task, index) => {

I understand your mean here is to filter out setupCategories and setupTags if users select the accounting connection. If so, the updated code should be:

    const tasksData = data.tasks.filter(task => !userReportedIntegration || (task.type != 'setupCategories' && task.type != 'setupTags')).map((task, index) => {

Is it correct?

@dukenv0307 yes, thanks for the correction. Updated proposal

[dukenv0307]

@jaydamani's proposal look good to me. We should hide the "Setup Categories" and "Setup Tags" in case users select an accounting connection

🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @chiragsalian, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[davidcardoza]

The op of the issue has been update to reflect recent conversations around combining the tasks rather than removing then. @marcaaron I looped you in per the convo in the linked Slack conversation.

[jaydamani]

Updated proposal based on this.
Also, @davidcardoza @marcaaron please share the task description/title and any other relevant details if it was discussed in the slack conversation as external contributors can not access it. I have added some placeholder strings for now.

[marcaaron]

Ok, so seems like we want this for the task content @jaydamani can you update your proposal. What you have there now doesn't seem correct.

[marcaaron]

Everything else looks good.

[greg-schroeder]

seems the deploy blocker is incorrect, hiding it as off topic

[greg-schroeder]

This is on staging. Awaiting deploy to prod

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.64-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• feature(onboarding): combine category and tag setup task for connections #51926

If no regressions arise, payment will be issued on 2024-11-28. 🎊

For reference, here are some details about the assignees on this issue:

• @jaydamani requires payment (Needs manual offer from BZ)
• @dukenv0307 requires payment through NewDot Manual Requests

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@dukenv0307] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@greg-schroeder] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[dukenv0307]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other: New feature

Where bug was reported:

• 2a. Reported on production
• 2b. Reported on staging (deploy blocker)
• 2c. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: This issue is new feature so no need to point out offending PR

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: N/A

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again. Yes

Regression Test Proposal Template

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

Test:

1. Create a new user
2. Verify that the "What do you want to do today?" modal appears
3. Select the option "Manage my team's expenses"> 1-10 employees> Netsuite> Complete
4. Go to workspace settings> Set up categories and tags
5. Go to Concierge chat and check Set up categories and tags Task

Do we agree 👍 or 👎

[melvin-bot]

Payment Summary

Upwork Job

• ROLE: @jaydamani paid $(AMOUNT) via Upwork (LINK)
• Reviewer: @dukenv0307 owed $250 via NewDot

BugZero Checklist (@greg-schroeder)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021862321644417750071

[melvin-bot]

Current assignee @dukenv0307 is eligible for the External assigner, not assigning anyone new.

[greg-schroeder]

Payment summary:

Contributor: @jaydamani - $250 - Sent offer via Upwork
C+: @dukenv0307 - $250 - Manual request via NewDot

[greg-schroeder]

Filed regression test