Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concierge - Set up categories and tags task is not auto-completed when set both #52755

Closed
3 of 8 tasks
IuliiaHerets opened this issue Nov 19, 2024 · 9 comments
Closed
3 of 8 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@IuliiaHerets
Copy link

IuliiaHerets commented Nov 19, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.64-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5238615&group_by=cases:section_id&group_order=asc&group_id=229043
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

  1. Create a new user
  2. Verify that the "What do you want to do today?" modal appears
  3. Select the option "Manage my team's expenses"> 1-10 employees> Netsuite> Complete
  4. Go to workspace settings> Set up categories and tags
  5. Go to Concierge chat and check Set up categories and tags Task

Expected Result:

After setting new category and tag this Task in Concierge chat should be auto-completed

Actual Result:

Set up categories and tags task in Concierge chat is not auto-completed when set category and tags

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6669228_1732006812385.Recording__4541.mp4

View all open jobs on GitHub

@IuliiaHerets IuliiaHerets added DeployBlockerCash This issue or pull request should block deployment Bug Something is broken. Auto assigns a BugZero manager. labels Nov 19, 2024
Copy link

melvin-bot bot commented Nov 19, 2024

Triggered auto assignment to @grgia (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Nov 19, 2024

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Nov 19, 2024

💬 A slack conversation has been started in #expensify-open-source

@melvin-bot melvin-bot bot added the Daily KSv2 label Nov 19, 2024
@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Nov 19, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@grgia
Copy link
Contributor

grgia commented Nov 19, 2024

Related to #51926

@grgia
Copy link
Contributor

grgia commented Nov 19, 2024

This doesn't need to block deploy, but is potentially a regression from the linked PR cc @dukenv0307 @jaydamani

@grgia grgia removed the Hourly KSv2 label Nov 19, 2024
@jaydamani
Copy link
Contributor

Based on this, the task should not auto complete for now. @davidcardoza @marcaaron can you please confirm this.

@marcaaron
Copy link
Contributor

Not a bug. This is the expected behavior.

@marcaaron
Copy link
Contributor

After setting new category and tag this Task in Concierge chat should be auto-completed

This could be a potential improvement. But we said it would be manual and that auto-completing is out of scope for reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

6 participants