Deploy Checklist: New Expensify 2024-11-19

[github-actions]

Release Version: 9.0.64-4
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Do not set optimistic nvp_onboarding for invited users #51440
• fix: incorrect message displayed when deleting workspace #51444
• fix: Deleted room is displayed in the 'Assign task' #51625
• fix: sound plays before paying held expense report #51724
• feature(onboarding): combine category and tag setup task for connections #51926
• fix image from opening in both a new tab and app modal #52013
• fix: attachment menu position #52021
• fix: Not found page appear briefly after updating the first approver #52163
• [No QA] chore: remove isPolicyExpenseChat from Report #52233
• Fix search icon is unresponsive #52304
• cleanup: refactor TaxOptions to their own utils #52309
• Fix search item highlight doesn't have rounded edges #52351
• Make the video playback speed options scrollable #52354
• [No QA] chore: remove displayName and errors from Report type #52395
• Display not found page for invalid magic code #52407
• fix condition by adding check if taxes are enabled #52462
• Fix distance amount changes after submitting track distance expense with description #52482
• [No QA] Remove unused parameter for short lived authToken #52501
• Fix ValidateCodeActionModal dismissed when re-connect #52523
• Improve Switch to Expensify Classic flow #52526
• Priority Mode: Focus - Hide LHN reports that don't have parent access #52533
• fix: cannot set emoji status on safari #52538
• [No QA] Update Configure-Quickbooks-Online.md #52594
• Fix validate page navigation #52603
• Add upgrade flow for report field feature in qbo/xero #52607
• Pass policy data to completePaymentOnboarding #52610
• [NO QA]Validating keys from Report type #52619
• Remove plus icon on workspace switcher modal #52623
• Remove old Fastlane Action workaround fix #52630
• [No QA]Allow Android Rollout Bumper to be run manually and add key to fix error #52644
• [No QA]Fix Android Bumper (again) #52646
• Onboarding tasks copy change for settings tab #52653
• Don't complete onboarding if not an invited user #52656
• #2 - Fix blank space is shown on iOS safari when magic code screen show #52657
• fixes issue [Create expense button on empty Search page allows to create expense for non-migrated users] #52660
• [NOQA] Updating NewHelp for mobile layout #52683
• Call reconnectApp instead of openApp when ND is reopened in hybrid #52694
• [NO QA] docs: update storybook-example.png reference #52701
• [CP Staging] Fix: Context Menu Remains Open on Mweb #52752
• Fix compare image function #52757
• [CP Staging] Revert "Call reconnectApp instead of openApp when ND is reopened in hybrid" #52793
• [CP Staging] Revert "Fix distance amount changes after submitting track distance expense with description" #52814

Deploy Blockers:

• [HOLD for payment 2024-11-29] mWeb - Chat -Contextual menu does not close on selecting delete, edit comment & reply in thread opt #52744
• [HOLD for payment 2024-11-29] [HOLD for payment 2024-11-28] Hybrid - Login-App flickers when login and Splash screen is displayed every time #52746
• [HOLD for payment 2024-11-29] [HOLD for payment 2024-11-28] [$250] Attachment- Hmm it's not here page occur when expanding attached video #52747
• Hold - Emoji context menu doesn't close when hold RHN modal opens #52749
• MacOS - Report Action - No strike through and gray opacity is applied on offline deleted message #52753
• Concierge - Set up categories and tags task is not auto-completed when set both #52755
• Hybrid - Android - Workspace - currency list is empty when creating a workspace #52759
• Track expense - Error when submitting track distance expense to new workspace #52787
• Hybrid Android - Chat - White area appears behind keyboard as keyboard is pulling up #52816

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/9.0.64-0 🚀

[izarutskaya]

Regression is at 30% completed.
We waiting iOS build

Unchecked PRs:
#51444 - Failing on Web with original #50671
#51625 - Failing with original #50418 in offline tests

Blockers:
#52744
#52746
#52747

[grgia]

Demoted #52755

[cristipaval]

Checked off #52744 as it's been cp'd.

[Julesssss]

I haven't checked it off yet, but #52749 should have been fixed by the latest CP. I asked here for a retest

[kavimuru]

Regression is 25% left
iOS hybrid app is not updated yet and all the PRs are pending validation in iOS platform.

Unchecked PRs
#51444 - Failing on Web with original #50671
#51625 - Failing with original #50418 in offline tests
#51724 failing in android with #52772 repro in PROD, will check it of once verified in iOS
#52163 blocked with #52746
#52526 failing with #52756
#52653 failing with #52760 repro in PROD, will check it off once verified in iOS

[izarutskaya]

Regression is 22% left

Unchecked PRs:
#51444 - Failing on Web with original #50671
#51625 - Failing with original #50418 in offline tests
#51724 - Failing on Android with #52772 Pending validation on iOS
#52163 - blocked with #52746
#52021 - KI found #52747
#52309 - KI found #52748
#52354 - KI found #52747
#52526 - Failing on #52756
#52653 - Failing with #52760
#52752 - KI #52746

Blockers:
#52746
#52747
#52753
#52759
#52787

[Beamanator]

Checked off #52759 b/c i couldn't reproduce

[rlinoz]

Checking off #52787 fixed here #52787 (comment)

[kavimuru]

Regression is 16% left

Unchecked PRs:
#51440 - iOS validation is pending
#51444 - iOS validation is pending and also
failing on Web with original
#50671
#51625 - Failing with original #50418 in offline tests and iOS validation is pending
#51724 - with #52772 in iOS and Android, repro in PROD checking it off
#51926 - iOS validation is pending
#52309 - failing with #52748 repro in PROD. I will check it off once the iOS platform testing completed.
#52407 Android and iOS validations are pending
#52462 - iOS validation is pending
#52526 - Failing on #52756, iOS and Android validations are pending
#52610 - Pending validation in iOS
#52653 - Failing with #52760 and iOS validation is pending
#52656 - iOS validation is pending
#52657 - iOS validation is pending
#52660 - iOS validation is pending
#52694 - iOS validation is pending
#52533 - iOS validation is pending

[chiragsalian]

@kavimuru can you retest - #52746 when you get the chance. We CP'd a revert to address the issue.

[kavimuru]

@chiragsalian bug is fixed in both iOS and Android.

[kavimuru]

Regression is 5% left

Unchecked PRs:
#51444 - Failing on Web with original bug #50671
#51625 - Failing with original #50418 in offline tests
#52407 blocked, user is redirected to mweb clicking on the magic code
#52526 - Failing on #52756 and iIn android and iOS this is blocked and commented here #52526 (comment)
#52653 - Failing with #52760
#52656 - blocked in android with #52199

[chiragsalian]

#51444 - i checked it off and left a comment in the PR for author to make a follow up.
#51625 - i checked it off. Looks like there is an ongoing discussion and it doesn't sound like a blocker for us regardless.
#52407 - i don't follow what you posted @kavimuru, i don't think the feature is supposed to work on mobile native. and if it works fine on mweb that sounds good to me. Can you rephrase what the issue is? Also feel free to post on the issue for the author/reviewers to also confirm.
#52526 - Looks like there is an active discussion in #52756 and it doesn't look like a blocker.
#52653 - Looks like the failing issue will be handled separately in #52760. Seems like a fix is already out but just not CP'd so no reason to block on this. Checking it off.
#52656 - Checking it off since its working everywhere else and #52199 is currently in progress.

[kavimuru]

Regression is completed

#52407 This is the behavior in app

RPReplay_Final1732117400.MP4

[chiragsalian]

Hmm to test #52407 you need to logout first. i don't think its intended to do anything if you are logged in.

[chiragsalian]

I did a quick test of #52407 on web and mobile and it looks fine to me so I'm checking it off the list.

[kavimuru]

It is working in both web, desktop and mweb, but in native it is not working.

az_recorder_20241120_193749.1.mp4

[chiragsalian]

@kavimuru, could you retest this blocker - #52744.
The PR to fix it has been CP'd.

[chiragsalian]

It is working in both web, desktop and mweb, but in native it is not working.

Sounds good. I informed the author. I think its fine to keep it checked off in the checklist since it shouldn't be a blocker for us.

[kavimuru]

Bug is not reproduced #52744

screenrecording_11-21-2024_07-53-14_1.mp4

[chiragsalian]

#52526 - I'll check this off. Looks like there is an active discussion in #52756 and it doesn't look like it should be a blocker to me.

[chiragsalian]