Display not found page for invalid magic code #52407

mkzie2 · 2024-11-12T15:47:41Z

Explanation of Change

Display not found page for invalid magic code

Fixed Issues

$ #52124
PROPOSAL: #52124 (comment)

Tests

On native we don't use the validate code modal then we can skip this bug for native

Logout
Access the magic code link with an invalid magic code i.e. https://dev.new.expensify.com:8082/v/18364878/6236**93
Verify that the not found page appears

Verify that no errors appear in the JS console

Offline tests

None

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

On native we don't use the validate code modal then we can skip this bug for native

Logout
Access the magic code link with an invalid magic code i.e. https://staging.new.expensify.com/v/18364878/6236**93
Verify that the not found page appears

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

Screen.Recording.2024-11-12.at.22.30.06.mov

iOS: Native

iOS: mWeb Safari

Screen.Recording.2024-11-12.at.22.32.03.mov

MacOS: Chrome / Safari

Screen.Recording.2024-11-12.at.22.28.04.mov

MacOS: Desktop

Screen.Recording.2024-11-12.at.22.43.11.mov

melvin-bot · 2024-11-13T16:26:40Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

DylanDylann · 2024-11-14T10:47:37Z

src/components/ValidateCode/ValidateCodeModal.tsx

    const signInHere = useCallback(() => Session.signInWithValidateCode(accountID, code), [accountID, code]);
    const {translate} = useLocalize();

+    const isInvalidValidateCode = !ValidationUtils.isValidValidateCode(code);
+
+    if (isInvalidValidateCode) {


@mkzie2 I prefer to use FullPageNotFoundView as a wrapper for cleaner. Could you help to update it?

@DylanDylann I updated.

DylanDylann · 2024-11-15T05:00:27Z

@mkzie2 let's hide the back button on the wide screen like this

App/src/pages/home/ReportScreen.tsx

Line 737 in a6f1348

shouldShowBackButton={shouldUseNarrowLayout}

DylanDylann · 2024-11-15T05:12:19Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

Screen.Recording.2024-11-15.at.12.20.45.mov

iOS: Native

iOS: mWeb Safari

Screen.Recording.2024-11-15.at.12.19.27.mov

MacOS: Chrome / Safari

Screen.Recording.2024-11-15.at.12.18.09.mov

MacOS: Desktop

Screen.Recording.2024-11-15.at.12.21.51.mov

dangrous

great!

OSBotify · 2024-11-15T17:11:05Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-11-19T01:22:32Z

🚀 Deployed to staging by https://github.com/dangrous in version: 9.0.64-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

chiragsalian · 2024-11-21T00:44:47Z

QA mentions that this isn't working on native, posted here
I checked it off the QA checklist since its shouldn't be a blocker but check out this pending issue when you get a chance.

github-actions · 2024-11-21T01:16:29Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 9.0.64-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

DylanDylann · 2024-11-21T08:13:42Z

On native we don't display the validated code modal, should we display the not found page in the case of this issue or not?

@mkzie2 Please update step to exclude the native platform

mkzie2 · 2024-11-21T08:20:30Z

On native we don't use the validate code modal then we can skip this bug for native

@DylanDylann Updated.

cc @chiragsalian

mkzie2 added 3 commits November 12, 2024 22:44

display not found page for invalid magic code

5c5dcf2

Merge branch 'main' into mkzie2-issue/52124

20cb80a

remove withOnyx

b29da7b

mkzie2 marked this pull request as ready for review November 13, 2024 16:26

mkzie2 requested a review from a team as a code owner November 13, 2024 16:26

melvin-bot bot requested review from DylanDylann and removed request for a team November 13, 2024 16:26

mkzie2 mentioned this pull request Nov 13, 2024

[HOLD for payment 2024-11-28] [$250] Login - Incorrect page with an incorrect MC is shown when navigating to an invalid MC link #52124

Closed

8 tasks

DylanDylann reviewed Nov 14, 2024

View reviewed changes

mkzie2 added 2 commits November 14, 2024 23:53

Merge branch 'main' into mkzie2-issue/52124

a15ba6c

use FullPageNotFoundView

022cbdf

mkzie2 added 2 commits November 15, 2024 12:05

Merge branch 'main' into mkzie2-issue/52124

cfff1f6

hide back button in wide screen

5ab2011

DylanDylann approved these changes Nov 15, 2024

View reviewed changes

melvin-bot bot requested a review from dangrous November 15, 2024 06:56

dangrous approved these changes Nov 15, 2024

View reviewed changes

dangrous merged commit a54f913 into Expensify:main Nov 15, 2024
17 checks passed

github-actions bot mentioned this pull request Nov 19, 2024

Deploy Checklist: New Expensify 2024-11-19 #52733

Closed

54 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Display not found page for invalid magic code #52407

Display not found page for invalid magic code #52407

mkzie2 commented Nov 12, 2024 •

edited

Loading

melvin-bot bot commented Nov 13, 2024

DylanDylann Nov 14, 2024

mkzie2 Nov 14, 2024

DylanDylann commented Nov 15, 2024

DylanDylann commented Nov 15, 2024 •

edited

Loading

dangrous left a comment

OSBotify commented Nov 15, 2024

github-actions bot commented Nov 19, 2024

chiragsalian commented Nov 21, 2024

github-actions bot commented Nov 21, 2024

DylanDylann commented Nov 21, 2024

mkzie2 commented Nov 21, 2024 •

edited

Loading

Display not found page for invalid magic code #52407

Display not found page for invalid magic code #52407

Conversation

mkzie2 commented Nov 12, 2024 • edited Loading

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Nov 13, 2024

DylanDylann Nov 14, 2024

Choose a reason for hiding this comment

mkzie2 Nov 14, 2024

Choose a reason for hiding this comment

DylanDylann commented Nov 15, 2024

DylanDylann commented Nov 15, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

dangrous left a comment

Choose a reason for hiding this comment

OSBotify commented Nov 15, 2024

github-actions bot commented Nov 19, 2024

chiragsalian commented Nov 21, 2024

github-actions bot commented Nov 21, 2024

DylanDylann commented Nov 21, 2024

mkzie2 commented Nov 21, 2024 • edited Loading

mkzie2 commented Nov 12, 2024 •

edited

Loading

DylanDylann commented Nov 15, 2024 •

edited

Loading

mkzie2 commented Nov 21, 2024 •

edited

Loading