[HOLD for payment 2024-11-29] mWeb - Chat -Contextual menu does not close on selecting delete, edit comment & reply in thread opt

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.64-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5237958
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

1. Navigate to staging.new.expensify.com
2. Go to 1:1 DM
3. Send message
4. Long press on the message for the action menu to open
5. Select either, delete comment, edit comment or reply in thread options (Note: Contextual menu does not close)
6. Select any of the 3 emojis displayed in the menu (Note: Contextual menu does not close)

Expected Result:

Contextual menu should close automatically when selecting delete comment, edit commnet or reply in thread options

Actual Result:

Contextual menu does not close automatically when selecting delete, edit comment & reply in thread options
When delete comment option is selected, the action menu does not close & the confirmation modal is displayed behind the action menu.
Same issue happens when selecting reply in thread & edit comment options. User has to tap anywhere outside to close the menu

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6669002_1731981599811.az_recorder_20241118_205728.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @bfitzexpensify

[melvin-bot]

Triggered auto assignment to @cristipaval (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Contextual menu does not close automatically when selecting delete, edit comment & reply in thread options
When delete comment option is selected, the action menu does not close & the confirmation modal is displayed behind the action menu.
Same issue happens when selecting reply in thread & edit comment options. User has to tap anywhere outside to close the menu

What is the root cause of that problem?

This comes from #52021

We removed the logic to close the context menu here

App/src/pages/home/report/ContextMenu/ReportActionContextMenu.ts

Lines 66 to 68 in f77087f

	if (!shouldDelay) {
	onHideCallback();
	return;

What changes do you think we should make in order to solve the problem?

We should bring this back and we can only hide the context menu if we're in small screen width

if (!shouldDelay) { 
     contextMenuRef.current.hideContextMenu(onHideCallback);
     return; 
}

App/src/pages/home/report/ContextMenu/ReportActionContextMenu.ts

Lines 66 to 68 in f77087f

	if (!shouldDelay) {
	onHideCallback();
	return;

What alternative solutions did you explore? (Optional)

[rojiphil]

@teneeto Can we raise a quick PR to fix this?

[teneeto]

Adding a fix now

[teneeto]

Please assign issue to me

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[IuliiaHerets]

Edit box is not auto-focused when editing a comment. Is it the same root or need to create a new issue?

Bug6669220_1732005879731.2024-11-19_11_43_35.mp4

[rojiphil]

Edit box is not auto-focused when editing a comment. Is it the same root or need to create a new issue?

@IuliiaHerets Yeah. It is the same root cause and will be fixed with the PR for this issue.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[IuliiaHerets]

Pin/Unpin modal is not dismissed after selecting too

[rojiphil]

@cristipaval The PR is ready for review. Please have a look. Thanks.

[chiragsalian]

Not a blocker, tested and confirmed here that the CP worked.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.64-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix: Context Menu Remains Open on Mweb #52752

If no regressions arise, payment will be issued on 2024-11-28. 🎊

For reference, here are some details about the assignees on this issue:

• @rojiphil requires payment (Needs manual offer from BZ)
• @teneeto does not require payment (Contractor)

[melvin-bot]

@rojiphil @bfitzexpensify @rojiphil The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.65-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix: Context Menu Remains Open on Mweb #52752

If no regressions arise, payment will be issued on 2024-11-29. 🎊

For reference, here are some details about the assignees on this issue:

• @rojiphil requires payment (Needs manual offer from BZ)
• @teneeto does not require payment (Contractor)

[melvin-bot]

@rojiphil @bfitzexpensify @rojiphil The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot]

Payment Summary

Upwork Job

• ROLE: @rojiphil paid $(AMOUNT) via Upwork (LINK)
• Contributor: @teneeto is from an agency-contributor and not due payment

BugZero Checklist (@bfitzexpensify)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[bfitzexpensify]

I believe this is a regression from #50818. Closing this out.