-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADDED] Activity type and location source found in real world data. #4
base: main
Are you sure you want to change the base?
[ADDED] Activity type and location source found in real world data. #4
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added snapshot of data that contains the new types.
schemas/Records.schema.json
Outdated
VISIT_ARRIVAL, | ||
visit_arrival, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{
"latitudeE7": 436468347,
"longitudeE7": -793912234,
"accuracy": 109,
"source": "VISIT_ARRIVAL",
"deviceTag": -1158676519,
"deviceDesignation": "PRIMARY",
"timestamp": "2018-01-23T14:03:34.135Z"
}
schemas/Records.schema.json
Outdated
VISIT_DEPARTURE, | ||
visit_departure, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{
"latitudeE7": 436466804,
"longitudeE7": -793918201,
"accuracy": 110,
"source": "VISIT_DEPARTURE",
"deviceTag": -1158676519,
"deviceDesignation": "PRIMARY",
"timestamp": "2018-01-23T21:59:35.998Z"
}
schemas/Semantic.schema.json
Outdated
{ | ||
"type": "string", | ||
"const": "TYPE_UNKNOWN", | ||
"title": "Type Unknown Location", | ||
"description": "Location type is unknown", | ||
"extra_color": "#03a9f4", | ||
"extra_icon": "semantic_types/label_circled_24dp.svg" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{
"latitudeE7": 427012790,
"longitudeE7": -788526840,
"placeId": "Chklm2Fe-r8TK4gRkgyI7imTse0",
"address": "Brampton, ON L7A, Canada",
"name": "Creditview Rd s/of Kilkarrin Rd",
"semanticType": "TYPE_UNKNOWN",
"locationConfidence": 0.100103855,
"calibratedProbability": 0.100103855
}
Hi! Thanks for using the project and contributing! I think that the Can you check that? |
Yes, you are right. I double-checked, and I have mixed up records activity with semantic activities. |
"extra_color": "#03a9f4", | ||
"extra_icon": "activity_types/moving_24dp.svg" | ||
"extra_icon": "activity_types/unknown_24dp.svg" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't realize that the icons are from https://github.com/CarlosBergillos/LocationHistoryFormat/tree/main/docs/static/icons/activity_types and used in the generated docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"title": "Type Unknown Location", | ||
"description": "Location type is unknown", | ||
"extra_color": "#03a9f4", | ||
"extra_icon": "semantic_types/unknown_24dp.svg" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here - the icon does not exists in https://github.com/CarlosBergillos/LocationHistoryFormat/tree/main/docs/static/icons/semantic_types - what should I use here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I haven't encountered this one!
In this case (semantic type) the icons are also based on what is shown in the web interface.
If you have access to the Google account where this TYPE_UNKNOWN
was found, can you navigate to that day in the Google Maps Timeline web interface and see how it looks there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks very similar.
This type shows up in the "otherCandidateLocations"
location items. Eg.
{
"placeVisit": {
"location": {
"semanticType": "TYPE_HOME",
"locationConfidence": 100.0,
"calibratedProbability": 100.0
},
"duration": {
"startTimestamp": "2024-03-04T02:34:29Z",
"endTimestamp": "2024-03-04T13:42:14Z"
},
"placeConfidence": "USER_CONFIRMED",
"visitConfidence": 100,
"otherCandidateLocations": [
{
"placeId": "Ch...wY",
"address": "Address, City, State 12345, Country",
"name": "Place Name",
"semanticType": "TYPE_UNKNOWN",
"locationConfidence": 37.953373,
"calibratedProbability": 37.953373
}
],
"editConfirmationStatus": "CONFIRMED",
"locationConfidence": 100,
"placeVisitType": "SINGLE_PLACE",
"locationAssertionType": "WITHIN_OR_AT",
"lastEditedTimestamp": "2024-03-13T00:37:59.560Z",
"placeVisitImportance": "MAIN"
}
}
"MANUAL", | ||
"manual", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CarlosBergillos Found another new type from different user's export.
{
"latitudeE7": 429362606,
"longitudeE7": -778308950,
"accuracy": 4,
"velocity": 0,
"altitude": 169,
"verticalAccuracy": 3,
"source": "MANUAL",
"deviceTag": -379135184,
"platformType": "IOS",
"serverTimestamp": "2023-11-30T22:30:02.016Z",
"deviceTimestamp": "2023-11-30T22:30:01.943Z",
"batteryCharging": false,
"formFactor": "PHONE",
"timestamp": "2023-11-30T22:30:01Z"
}
Summary
Added some types that were observed in Google Location History Takeout data dump.