Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADDED] Activity type and location source found in real world data. #4

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

[ADDED] Activity type and location source found in real world data. #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
693d12e
[ADDED] Activity type and location source found in real world data.
hossain-khan Mar 16, 2024
b71ecfe
[FIXED] Removed wrongly added Activity Type that belongs to `Records`
hossain-khan Mar 20, 2024
2fd3f95
[MINOR] Use same naming convention for the icons
hossain-khan Mar 20, 2024
952e2ce
Merge branch 'CarlosBergillos:main' into hk/update-json-schema
hossain-khan Mar 25, 2024
017c00d
[FIXED] New enum string type error
hossain-khan Mar 25, 2024
4b224d1
[ADDED] New location source type found from another users's export
hossain-khan Mar 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions schemas/Records.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,6 +333,12 @@
"cell",
"GPS",
"gps",
"MANUAL",
"manual",
Comment on lines +336 to +337
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CarlosBergillos Found another new type from different user's export.

{
    "latitudeE7": 429362606,
    "longitudeE7": -778308950,
    "accuracy": 4,
    "velocity": 0,
    "altitude": 169,
    "verticalAccuracy": 3,
    "source": "MANUAL",
    "deviceTag": -379135184,
    "platformType": "IOS",
    "serverTimestamp": "2023-11-30T22:30:02.016Z",
    "deviceTimestamp": "2023-11-30T22:30:01.943Z",
    "batteryCharging": false,
    "formFactor": "PHONE",
    "timestamp": "2023-11-30T22:30:01Z"
}

"VISIT_ARRIVAL",
"visit_arrival",
"VISIT_DEPARTURE",
"visit_departure",
"UNKNOWN",
"unknown"
]
Expand Down
14 changes: 11 additions & 3 deletions schemas/Semantic.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -890,10 +890,10 @@
{
"type": "string",
"const": "UNKNOWN_ACTIVITY_TYPE",
"title": "Moving",
"description": "",
"title": "Uknown Activity",
"description": "Type used when unable to detect the current activity.",
"extra_color": "#03a9f4",
"extra_icon": "activity_types/moving_24dp.svg"
"extra_icon": "activity_types/unknown_24dp.svg"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't realize that the icons are from https://github.com/CarlosBergillos/LocationHistoryFormat/tree/main/docs/static/icons/activity_types and used in the generated docs

Screenshot 2024-03-20 231425

Copy link
Owner

@CarlosBergillos CarlosBergillos Apr 1, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The icons and titles (and colors) are actually based on the Google Maps Timeline web interface:

Screenshot_20240401_193709

So maybe we should keep it aligned with them? in this case "Moving".

},
{
"type": "string",
Expand Down Expand Up @@ -1232,6 +1232,14 @@
"description": "The place has been given a private label by the user. See: [Give a place a private label](https://support.google.com/maps/answer/6257830?hl=en).",
"extra_color": "#03a9f4",
"extra_icon": "semantic_types/label_circled_24dp.svg"
},
{
"type": "string",
"const": "TYPE_UNKNOWN",
"title": "Type Unknown Location",
"description": "Location type is unknown",
"extra_color": "#03a9f4",
"extra_icon": "semantic_types/unknown_24dp.svg"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here - the icon does not exists in https://github.com/CarlosBergillos/LocationHistoryFormat/tree/main/docs/static/icons/semantic_types - what should I use here?

Copy link
Owner

@CarlosBergillos CarlosBergillos Apr 1, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I haven't encountered this one!
In this case (semantic type) the icons are also based on what is shown in the web interface.

Screenshot_20240401_194925

If you have access to the Google account where this TYPE_UNKNOWN was found, can you navigate to that day in the Google Maps Timeline web interface and see how it looks there?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks very similar.

Screenshot 2024-04-13 232530

This type shows up in the "otherCandidateLocations" location items. Eg.

{
    "placeVisit": {
        "location": {
            "semanticType": "TYPE_HOME",
            "locationConfidence": 100.0,
            "calibratedProbability": 100.0
        },
        "duration": {
            "startTimestamp": "2024-03-04T02:34:29Z",
            "endTimestamp": "2024-03-04T13:42:14Z"
        },
        "placeConfidence": "USER_CONFIRMED",
        "visitConfidence": 100,
        "otherCandidateLocations": [
            {
                "placeId": "Ch...wY",
                "address": "Address, City, State 12345, Country",
                "name": "Place Name",
                "semanticType": "TYPE_UNKNOWN",
                "locationConfidence": 37.953373,
                "calibratedProbability": 37.953373
            }
        ],
        "editConfirmationStatus": "CONFIRMED",
        "locationConfidence": 100,
        "placeVisitType": "SINGLE_PLACE",
        "locationAssertionType": "WITHIN_OR_AT",
        "lastEditedTimestamp": "2024-03-13T00:37:59.560Z",
        "placeVisitImportance": "MAIN"
    }
}

}
]
},
Expand Down
Loading