-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADDED] Activity type and location source found in real world data. #4
base: main
Are you sure you want to change the base?
Changes from all commits
693d12e
b71ecfe
2fd3f95
952e2ce
017c00d
4b224d1
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -890,10 +890,10 @@ | |
{ | ||
"type": "string", | ||
"const": "UNKNOWN_ACTIVITY_TYPE", | ||
"title": "Moving", | ||
"description": "", | ||
"title": "Uknown Activity", | ||
"description": "Type used when unable to detect the current activity.", | ||
"extra_color": "#03a9f4", | ||
"extra_icon": "activity_types/moving_24dp.svg" | ||
"extra_icon": "activity_types/unknown_24dp.svg" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I didn't realize that the icons are from https://github.com/CarlosBergillos/LocationHistoryFormat/tree/main/docs/static/icons/activity_types and used in the generated docs There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
}, | ||
{ | ||
"type": "string", | ||
|
@@ -1232,6 +1232,14 @@ | |
"description": "The place has been given a private label by the user. See: [Give a place a private label](https://support.google.com/maps/answer/6257830?hl=en).", | ||
"extra_color": "#03a9f4", | ||
"extra_icon": "semantic_types/label_circled_24dp.svg" | ||
}, | ||
{ | ||
"type": "string", | ||
"const": "TYPE_UNKNOWN", | ||
"title": "Type Unknown Location", | ||
"description": "Location type is unknown", | ||
"extra_color": "#03a9f4", | ||
"extra_icon": "semantic_types/unknown_24dp.svg" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same here - the icon does not exists in https://github.com/CarlosBergillos/LocationHistoryFormat/tree/main/docs/static/icons/semantic_types - what should I use here? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Oh, I haven't encountered this one! If you have access to the Google account where this There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It looks very similar. This type shows up in the {
"placeVisit": {
"location": {
"semanticType": "TYPE_HOME",
"locationConfidence": 100.0,
"calibratedProbability": 100.0
},
"duration": {
"startTimestamp": "2024-03-04T02:34:29Z",
"endTimestamp": "2024-03-04T13:42:14Z"
},
"placeConfidence": "USER_CONFIRMED",
"visitConfidence": 100,
"otherCandidateLocations": [
{
"placeId": "Ch...wY",
"address": "Address, City, State 12345, Country",
"name": "Place Name",
"semanticType": "TYPE_UNKNOWN",
"locationConfidence": 37.953373,
"calibratedProbability": 37.953373
}
],
"editConfirmationStatus": "CONFIRMED",
"locationConfidence": 100,
"placeVisitType": "SINGLE_PLACE",
"locationAssertionType": "WITHIN_OR_AT",
"lastEditedTimestamp": "2024-03-13T00:37:59.560Z",
"placeVisitImportance": "MAIN"
}
} |
||
} | ||
] | ||
}, | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CarlosBergillos Found another new type from different user's export.