-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADDED] Activity type and location source found in real world data. #4
Open
hossain-khan
wants to merge
6
commits into
CarlosBergillos:main
Choose a base branch
from
hossain-khan:hk/update-json-schema
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
693d12e
[ADDED] Activity type and location source found in real world data.
hossain-khan b71ecfe
[FIXED] Removed wrongly added Activity Type that belongs to `Records`
hossain-khan 2fd3f95
[MINOR] Use same naming convention for the icons
hossain-khan 952e2ce
Merge branch 'CarlosBergillos:main' into hk/update-json-schema
hossain-khan 017c00d
[FIXED] New enum string type error
hossain-khan 4b224d1
[ADDED] New location source type found from another users's export
hossain-khan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -333,6 +333,10 @@ | |
"cell", | ||
"GPS", | ||
"gps", | ||
VISIT_ARRIVAL, | ||
visit_arrival, | ||
VISIT_DEPARTURE, | ||
visit_departure, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. {
"latitudeE7": 436466804,
"longitudeE7": -793918201,
"accuracy": 110,
"source": "VISIT_DEPARTURE",
"deviceTag": -1158676519,
"deviceDesignation": "PRIMARY",
"timestamp": "2018-01-23T21:59:35.998Z"
} |
||
"UNKNOWN", | ||
"unknown" | ||
] | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -890,10 +890,18 @@ | |
{ | ||
"type": "string", | ||
"const": "UNKNOWN_ACTIVITY_TYPE", | ||
"title": "Moving", | ||
"description": "", | ||
"title": "Uknown Activity", | ||
"description": "Type used when unable to detect the current activity.", | ||
"extra_color": "#03a9f4", | ||
"extra_icon": "activity_types/moving_24dp.svg" | ||
"extra_icon": "activity_types/unknown.svg" | ||
}, | ||
{ | ||
"type": "string", | ||
"const": "UNKNOWN", | ||
"title": "Uknown Activity", | ||
"description": "Type used when unable to detect the current activity.", | ||
"extra_color": "#03a9f4", | ||
"extra_icon": "activity_types/unknown.svg" | ||
}, | ||
hossain-khan marked this conversation as resolved.
Show resolved
Hide resolved
|
||
{ | ||
"type": "string", | ||
|
@@ -911,6 +919,14 @@ | |
"extra_color": "#03a9f4", | ||
"extra_icon": "activity_types/directions_walk_24dp.svg" | ||
}, | ||
{ | ||
"type": "string", | ||
"const": "ON_FOOT", | ||
"title": "On Foot", | ||
"description": "", | ||
"extra_color": "#4db6ac", | ||
"extra_icon": "activity_types/directions_walk_24dp.svg" | ||
}, | ||
hossain-khan marked this conversation as resolved.
Show resolved
Hide resolved
|
||
{ | ||
"type": "string", | ||
"const": "CYCLING", | ||
|
@@ -919,6 +935,14 @@ | |
"extra_color": "#4db6ac", | ||
"extra_icon": "activity_types/directions_bike_24dp.svg" | ||
}, | ||
{ | ||
"type": "string", | ||
"const": "ON_BICYCLE", | ||
"title": "On bicycle", | ||
"description": "", | ||
"extra_color": "#4db6ac", | ||
"extra_icon": "activity_types/directions_bike_24dp.svg" | ||
}, | ||
hossain-khan marked this conversation as resolved.
Show resolved
Hide resolved
|
||
{ | ||
"type": "string", | ||
"const": "IN_VEHICLE", | ||
|
@@ -1190,6 +1214,14 @@ | |
"description": "", | ||
"extra_color": "#4db6ac", | ||
"extra_icon": "activity_types/paragliding_24dp.svg" | ||
}, | ||
{ | ||
"type": "string", | ||
"const": "TILTING", | ||
"title": "Tilting", | ||
"description": "The device angle relative to gravity changed significantly. This often occurs when a device is picked up from a desk or a user who is sitting stands up.", | ||
"extra_color": "#4db6ac", | ||
"extra_icon": "activity_types/moving_24dp.svg" | ||
} | ||
hossain-khan marked this conversation as resolved.
Show resolved
Hide resolved
|
||
] | ||
}, | ||
|
@@ -1232,6 +1264,14 @@ | |
"description": "The place has been given a private label by the user. See: [Give a place a private label](https://support.google.com/maps/answer/6257830?hl=en).", | ||
"extra_color": "#03a9f4", | ||
"extra_icon": "semantic_types/label_circled_24dp.svg" | ||
}, | ||
{ | ||
"type": "string", | ||
"const": "TYPE_UNKNOWN", | ||
"title": "Type Unknown Location", | ||
"description": "Location type is unknown", | ||
"extra_color": "#03a9f4", | ||
"extra_icon": "semantic_types/label_circled_24dp.svg" | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. {
"latitudeE7": 427012790,
"longitudeE7": -788526840,
"placeId": "Chklm2Fe-r8TK4gRkgyI7imTse0",
"address": "Brampton, ON L7A, Canada",
"name": "Creditview Rd s/of Kilkarrin Rd",
"semanticType": "TYPE_UNKNOWN",
"locationConfidence": 0.100103855,
"calibratedProbability": 0.100103855
} |
||
] | ||
}, | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.