CI: update Ubuntu and Perl versions #1305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CI pipeline was still being run on Ubuntu 20.04. Update it to the latest LTS version, 22.04. In the same vein, move to more recent versions of Perl.
marc-vanderwal
requested review from
mattias-p,
matsduf,
hannaeko,
a user and
tgreenx
Add more diagnostics of why the “PO files are tidy” fails by means of a git diff.
|
CI fails because of a failing test in |
|
Seems like I was correct. The new |
Upgrading the OS used by Github Actions to run tests on PRs from Ubuntu 20.04 to 22.04 caused an upgrade in the gettext package. However, the msgcat tool uses a slightly different line-breaking algorithm that now works correctly with words between double quotations marks. In order to make our automated tests pass, we need to fix the offending PO files ourselves. In the French translation, this commit also fixes two typos in msgstrs already affected by line breaking changes. It therefore seems that the code introduced by pull request zonemaster#1195 is more fragile than one might think. This means that other users, especially those who might want to install Zonemaster::Engine from CPAN, have an increased risk of failing unit tests for something that will not cause Zonemaster::Engine to malfunction. It might be desirable to disable the PO file formatting tests by default, and only run them on Github Actions, so that a user who installs Zonemaster::Engine from CPAN will succeed even if they happen to have a version of gettext different from the developers’ systems’.
marc-vanderwal
force-pushed
the
features/update-ci-os-version
branch
from
3039158 to
7f6495d
Compare
matsduf
approved these changes
Nov 16, 2023
tgreenx
approved these changes
Nov 16, 2023
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR updates the versions of Ubuntu and Perl to use in Github actions.
Context
Discussion during work group meeting.
Changes
How to test this PR
The Github Action should succeed.