-
Notifications
You must be signed in to change notification settings - Fork 34
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Reformat PO files according to gettext-0.21
Upgrading the OS used by Github Actions to run tests on PRs from Ubuntu 20.04 to 22.04 caused an upgrade in the gettext package. However, the msgcat tool uses a slightly different line-breaking algorithm that now works correctly with words between double quotations marks. In order to make our automated tests pass, we need to fix the offending PO files ourselves. In the French translation, this commit also fixes two typos in msgstrs already affected by line breaking changes. It therefore seems that the code introduced by pull request #1195 is more fragile than one might think. This means that other users, especially those who might want to install Zonemaster::Engine from CPAN, have an increased risk of failing unit tests for something that will not cause Zonemaster::Engine to malfunction. It might be desirable to disable the PO file formatting tests by default, and only run them on Github Actions, so that a user who installs Zonemaster::Engine from CPAN will succeed even if they happen to have a version of gettext different from the developers’ systems’.
- Loading branch information
1 parent
6284a56
commit 7f6495d
Showing
3 changed files
with
39 additions
and
39 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters