Skip to content

Commit

Permalink
Reformat PO files according to gettext-0.21
Browse files Browse the repository at this point in the history
Upgrading the OS used by Github Actions to run tests on PRs from
Ubuntu 20.04 to 22.04 caused an upgrade in the gettext package. However,
the msgcat tool uses a slightly different line-breaking algorithm that
now works correctly with words between double quotations marks.

In order to make our automated tests pass, we need to fix the offending
PO files ourselves. In the French translation, this commit also fixes
two typos in msgstrs already affected by line breaking changes.

It therefore seems that the code introduced by pull request #1195 is
more fragile than one might think. This means that other users,
especially those who might want to install Zonemaster::Engine from CPAN,
have an increased risk of failing unit tests for something that will not
cause Zonemaster::Engine to malfunction.

It might be desirable to disable the PO file formatting tests by
default, and only run them on Github Actions, so that a user who
installs Zonemaster::Engine from CPAN will succeed even if they happen
to have a version of gettext different from the developers’ systems’.
  • Loading branch information
marc-vanderwal committed Nov 16, 2023
1 parent 6284a56 commit 7f6495d
Show file tree
Hide file tree
Showing 3 changed files with 39 additions and 39 deletions.
50 changes: 25 additions & 25 deletions share/fr.po
Original file line number Diff line number Diff line change
Expand Up @@ -112,8 +112,8 @@ msgstr "Tous les enregistrements PTR correspondent aux serveurs de noms."
#, perl-brace-format
msgid "No response from nameserver(s) on PTR query ({domain})."
msgstr ""
"Aucune réponse des serveurs de noms sur une requête de type \"PTR"
"\" ({domain})."
"Aucune réponse des serveurs de noms sur une requête de type "
"\"PTR\" ({domain})."

#. ADDRESS:TEST_CASE_END
#. BASIC:TEST_CASE_END
Expand Down Expand Up @@ -867,22 +867,22 @@ msgstr ""
#, perl-brace-format
msgid "A single SOA mname value was seen ({mname})."
msgstr ""
"Un unique serveur maître a été trouvé dans les enregistrements de type \"SOA"
"\" de la zone testée ({mname})."
"Un unique serveur maître a été trouvé dans les enregistrements de type "
"\"SOA\" de la zone testée ({mname})."

#. CONSISTENCY:ONE_SOA_RNAME
#, perl-brace-format
msgid "A single SOA rname value was found ({rname})."
msgstr ""
"Une unique adresse mail a été trouvée dans les enregistrements de type \"SOA"
"\" de la zone testée ({rname})."
"Une unique adresse mail a été trouvée dans les enregistrements de type "
"\"SOA\" de la zone testée ({rname})."

#. CONSISTENCY:ONE_SOA_SERIAL
#, perl-brace-format
msgid "A single SOA serial number was found ({serial})."
msgstr ""
"Un unique numéro de série a été trouvé dans les enregistrements de type \"SOA"
"\" de la zone testée ({serial})."
"Un unique numéro de série a été trouvé dans les enregistrements de type "
"\"SOA\" de la zone testée ({serial})."

#. CONSISTENCY:ONE_SOA_TIME_PARAMETER_SET
#, perl-brace-format
Expand Down Expand Up @@ -1658,8 +1658,8 @@ msgid ""
"({ns_ip_list})."
msgstr ""
"Les serveurs de noms ayant une des adresses IP suivantes \"{ns_ip_list}\" "
"retournent un ensemble d'enregistrements de type \"CDNSKEY\" et de type \"CDS"
"\"."
"retournent un ensemble d'enregistrements de type \"CDNSKEY\" et de type "
"\"CDS\"."

#. DNSSEC:DS15_HAS_CDS_NO_CDNSKEY
#, perl-brace-format
Expand Down Expand Up @@ -1690,14 +1690,14 @@ msgid ""
"addresses ({ns_ip_list}) but they do not match."
msgstr ""
"Les serveurs de noms ayant une des adresses IP suivantes \"{ns_ip_list}\" "
"retournent un ensemble d'enregistrements de type \"CDNSKEY\" et de type \"CDS"
"\" mais ceux-ci ne correspondent pas."
"retournent un ensemble d'enregistrements de type \"CDNSKEY\" et de type "
"\"CDS\" mais ceux-ci ne correspondent pas."

#. DNSSEC:DS15_NO_CDS_CDNSKEY
msgid "No CDS or CDNSKEY RRsets are found on any name server."
msgstr ""
"Aucun des serveurs de noms ne retourne d'enregistrements de type \"CDNSKEY"
"\" ou de type \"CDS\"."
"Aucun des serveurs de noms ne retourne d'enregistrements de type \"CDNSKEY\" "
"ou de type \"CDS\"."

#. DNSSEC:DS16_CDS_INVALID_RRSIG
#, perl-brace-format
Expand Down Expand Up @@ -1868,9 +1868,9 @@ msgid ""
"\"{ns_ip_list}\"."
msgstr ""
"L'ensemble d'enregistrements de type \"CDNSKEY\" n'est pas signé par la clé "
"(DNSKEY) correspondant au tag {keytag} de l'enregistrement de type \"CDNSKEY"
"\". Information retournée par les serveurs de noms ayant une des adresses IP "
"suivantes \"{ns_ip_list}\"."
"(DNSKEY) correspondant au tag {keytag} de l'enregistrement de type "
"\"CDNSKEY\". Information retournée par les serveurs de noms ayant une des "
"adresses IP suivantes \"{ns_ip_list}\"."

#. DNSSEC:DS17_CDNSKEY_SIGNED_BY_UNKNOWN_DNSKEY
#, perl-brace-format
Expand Down Expand Up @@ -2399,8 +2399,8 @@ msgstr ""
msgid "Empty NOERROR response to SOA query was received from {ns}."
msgstr ""
"Une réponse à une requête pour un enregistrement de type \"SOA\" sur le "
"serveur de noms {ns} a été reçue vide alors que le code retour est \"NOERROR"
"\"."
"serveur de noms {ns} a été reçue vide alors que le code retour est "
"\"NOERROR\"."

#. DELEGATION:TOTAL_NAME_MISMATCH
msgid "None of the nameservers listed at the parent are listed at the child."
Expand Down Expand Up @@ -2490,8 +2490,8 @@ msgstr ""
#, perl-brace-format
msgid "Nameserver {ns} dropped AAAA query."
msgstr ""
"Le serveur de noms {ns} ne répond pas aux requêtes portant sur le type \"AAAA"
"\"."
"Le serveur de noms {ns} ne répond pas aux requêtes portant sur le type "
"\"AAAA\"."

#. NAMESERVER:AAAA_UNEXPECTED_RCODE
#, perl-brace-format
Expand Down Expand Up @@ -2843,8 +2843,8 @@ msgstr ""
#, perl-brace-format
msgid "Nameserver {ns} has one or more unknown EDNS Z flag bits set."
msgstr ""
"Le serveur de noms {ns} répond à une requête avec a un ou plusieurs bits \"Z"
"\" (EDNS) positionnés."
"Le serveur de noms {ns} répond à une requête avec un ou plusieurs bits "
"\"Z\" (EDNS) positionnés."

#. SYNTAX:SYNTAX01
msgid "No illegal characters in the domain name"
Expand Down Expand Up @@ -3427,8 +3427,8 @@ msgstr ""
msgid ""
"Non-authoritative response on MX query from name servers \"{ns_ip_list}\"."
msgstr ""
"La réponse des serveurs de noms \"{ns_ip_list}\" à une requête de type \"MX"
"\" ne fait pas autorité."
"La réponse des serveurs de noms \"{ns_ip_list}\" à une requête de type "
"\"MX\" ne fait pas autorité."

#. ZONE:Z09_NO_MX_FOUND
#, perl-brace-format
Expand Down
20 changes: 10 additions & 10 deletions share/nb.po
Original file line number Diff line number Diff line change
Expand Up @@ -1557,8 +1557,8 @@ msgid ""
"The CDS record with tag {keytag} matches a DNSKEY record with zone bit (bit "
"7) unset. Fetched from the nameservers with IP addresses \"{ns_ip_list}\"."
msgstr ""
"CDS-posten med \"key tag\" {keytag} matcher en DNSKEY-post uten \"zone bit"
"\" (bit 7) satt. Hentet fra navnetjenere med IP-adressene ({ns_ip_list})."
"CDS-posten med \"key tag\" {keytag} matcher en DNSKEY-post uten \"zone "
"bit\" (bit 7) satt. Hentet fra navnetjenere med IP-adressene ({ns_ip_list})."

#. DNSSEC:DS16_CDS_MATCHES_NO_DNSKEY
#, perl-brace-format
Expand All @@ -1576,8 +1576,8 @@ msgid ""
"{keytag} points to. Fetched from the nameservers with IP addresses "
"\"{ns_ip_list}\"."
msgstr ""
"CDS-posten er ikke signert av DNSKEY referert av CDS-posten med \"key tag"
"\" {keytag}. Hentet fra navnetjenere med IP-adressene ({ns_ip_list})."
"CDS-posten er ikke signert av DNSKEY referert av CDS-posten med \"key "
"tag\" {keytag}. Hentet fra navnetjenere med IP-adressene ({ns_ip_list})."

#. DNSSEC:DS16_CDS_SIGNED_BY_UNKNOWN_DNSKEY
#, perl-brace-format
Expand Down Expand Up @@ -1622,8 +1622,8 @@ msgid ""
"{keytag} points to. Fetched from the nameservers with IP addresses "
"\"{ns_ip_list}\"."
msgstr ""
"DNSKEY-posten er ikke signert av DNSKEY referert av CDS-posten med \"key tag"
"\" {keytag}. Hentet fra navnetjenere med IP-adressene ({ns_ip_list})."
"DNSKEY-posten er ikke signert av DNSKEY referert av CDS-posten med \"key "
"tag\" {keytag}. Hentet fra navnetjenere med IP-adressene ({ns_ip_list})."

#. DNSSEC:DS16_MIXED_DELETE_CDS
#, perl-brace-format
Expand Down Expand Up @@ -1679,8 +1679,8 @@ msgid ""
"tag {keytag} points to. Fetched from the nameservers with IP addresses "
"\"{ns_ip_list}\"."
msgstr ""
"CDNSKEY-posten er ikke signert av den DNSKEY som CDNSKEY-posten med \"key tag"
"\" {keytag} refererer til. Hentet fra navnetjenere med IP-adressene "
"CDNSKEY-posten er ikke signert av den DNSKEY som CDNSKEY-posten med \"key "
"tag\" {keytag} refererer til. Hentet fra navnetjenere med IP-adressene "
"({ns_ip_list})."

#. DNSSEC:DS17_CDNSKEY_SIGNED_BY_UNKNOWN_DNSKEY
Expand Down Expand Up @@ -1728,8 +1728,8 @@ msgid ""
"tag {keytag} points to. Fetched from the nameservers with IP addresses "
"\"{ns_ip_list}\"."
msgstr ""
"DNSKEY-posten er ikke signert av den DNSKEY som CDNSKEY-posten med \"key tag"
"\" {keytag} refererer til. Hentet fra navnetjenere med IP-adressene "
"DNSKEY-posten er ikke signert av den DNSKEY som CDNSKEY-posten med \"key "
"tag\" {keytag} refererer til. Hentet fra navnetjenere med IP-adressene "
"({ns_ip_list})."

#. DNSSEC:DS17_MIXED_DELETE_CDNSKEY
Expand Down
8 changes: 4 additions & 4 deletions share/sv.po
Original file line number Diff line number Diff line change
Expand Up @@ -1612,8 +1612,8 @@ msgid ""
"{keytag} points to. Fetched from the nameservers with IP addresses "
"\"{ns_ip_list}\"."
msgstr ""
"CDS RRset har inte signerats av den DNSKEY-post som CDS-posten med \"key tag"
"\" {keytag} refererar till. Hämtat från namnservrarna med IP-adresserna "
"CDS RRset har inte signerats av den DNSKEY-post som CDS-posten med \"key "
"tag\" {keytag} refererar till. Hämtat från namnservrarna med IP-adresserna "
"\"{ns_ip_list}\"."

#. DNSSEC:DS16_CDS_SIGNED_BY_UNKNOWN_DNSKEY
Expand Down Expand Up @@ -3058,8 +3058,8 @@ msgid ""
"SOA MNAME is specified as \".\" which usually means \"no server\". Fetched "
"from name servers \"{ns_ip_list}\"."
msgstr ""
"Namnservernamnet i SOA MNAME är \".\", vilket normalt betyder \"ingen server"
"\". Hämtad från namnservrarna med IP-adresserna \"{ns_ip_list}\"."
"Namnservernamnet i SOA MNAME är \".\", vilket normalt betyder \"ingen "
"server\". Hämtad från namnservrarna med IP-adresserna \"{ns_ip_list}\"."

#. ZONE:Z01_MNAME_IS_LOCALHOST
#, perl-brace-format
Expand Down

0 comments on commit 7f6495d

Please sign in to comment.