Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: update dependency and Perl versions #1140

Merged
5 commits merged into from Dec 7, 2023
Merged

CI: update dependency and Perl versions #1140

5 commits merged into from Dec 7, 2023

Conversation

ghost
Copy link

@ghost ghost commented Dec 4, 2023

Purpose

This PR adds a missing dependency and updates the Perl versions for Travis CI.

Context

zonemaster/zonemaster-engine#1305
zonemaster/zonemaster-engine#1287

Changes

  • Test against Perl 5.36, 5.30 and 5.26 instead of 5.30, 5.26 and 5.16;

How to test this PR

Travis should pass.

Alexandre Pion added 2 commits December 4, 2023 15:01
Zonemaster-Engine relies on Mail::SPF and there is a bug preventing its
installation from cpanm. See Zonemaster-Engine commit `3ac72b0c` and/or
pull request <zonemaster/zonemaster-engine#1287>
for more information on this.
@ghost ghost added this to the v2023.2 milestone Dec 4, 2023
@marc-vanderwal
Copy link
Contributor

marc-vanderwal commented Dec 4, 2023

Looks fine. Might as well update the distribution version; right now, it’s still using Bionic (i.e. 18.04 LTS) and Focal (20.04 LTS) instead of Jammy (22.04 LTS).

@marc-vanderwal
Copy link
Contributor

Better. But I wonder why Travis fails and why we can’t have the logs.

@tgreenx
Copy link
Contributor

tgreenx commented Dec 4, 2023

Better. But I wonder why Travis fails and why we can’t have the logs.

Unless I misunderstood you, you can see the logs in the usual "Checks" tab (https://github.com/zonemaster/zonemaster-backend/pull/1140/checks) and then clicking on any job number in the "Jobs and stages" section.

Right now this check is failing because Basic00 has just been removed in the develop branch of Engine and #1132 (which removes its usage in Backend) is not yet merged.

@marc-vanderwal
Copy link
Contributor

Better. But I wonder why Travis fails and why we can’t have the logs.

Unless I misunderstood you, you can see the logs in the usual "Checks" tab (https://github.com/zonemaster/zonemaster-backend/pull/1140/checks) and then clicking on any job number in the "Jobs and stages" section.

Right now this check is failing because Basic00 has just been removed in the develop branch of Engine and #1132 (which removes its usage in Backend) is not yet merged.

There might be an access issue, because all I see when I follow your steps (which is, incidentally, exactly what I tried) is this:
We’re sorry, but this data is not available. Please check the repository settings in Travis CI.

@mattias-p
Copy link
Member

I'm not currently logged into Travis (AFAICT) and I can see the Job log. Maybe they were having problem that's been fixed?
Anyway, here are the last few lines.

$ if [[ "$TARGET" == "PostgreSQL" ]]; then sudo sed -i 's/port = 5433/port = 5432/' /etc/postgresql/12/main/postgresql.conf; fi

sed: can't read /etc/postgresql/12/main/postgresql.conf: No such file or directory

The command "if [[ "$TARGET" == "PostgreSQL" ]]; then sudo sed -i 's/port = 5433/port = 5432/' /etc/postgresql/12/main/postgresql.conf; fi" failed and exited with 2 during .

Your build has been stopped.

@marc-vanderwal
Copy link
Contributor

I'm not currently logged into Travis (AFAICT) and I can see the Job log. Maybe they were having problem that's been fixed?

It seems unlikely, because I still can’t see those logs.

@mattias-p
Copy link
Member

Weird. I'm able to read it in a private browser window, so it seems unlikely to me that it's access related. Could it be some browser extension interfering?

@marc-vanderwal
Copy link
Contributor

Weird. I'm able to read it in a private browser window, so it seems unlikely to me that it's access related. Could it be some browser extension interfering?

Oh, excellent suggestion! Using a private browser window works for me as well.

In a non-private browser window, I then deleted all local storage in app.travis-ci.com. I signed back in and all is well again.

@matsduf
Copy link
Contributor

matsduf commented Dec 6, 2023

In a non-private browser window, I then deleted all local storage in app.travis-ci.com. I signed back in and all is well again.

After clearing the cookies for travis-ci.com I could see why Travis fails.

@ghost ghost merged commit 774cdc3 into zonemaster:develop Dec 7, 2023
1 check failed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants