log-viewer-webui: Add server implementation for submitting IR extraction jobs and serving IR files; Don't copy unnecessary files when building component. #458
Conversation
There was a problem hiding this comment.
Thanks a lot for picking up my backlog. Let's update some of the implementations after #460 is merged.
| fastify.post("/examples/post", async (req, resp) => { | ||
| return {msg: `Goodbye, ${req.body.name}!`}; | ||
| fastify.post("/decompression_job", async (req, resp) => { | ||
| const result = await fastify.dbManager.insertDecompressionJob(req.body); |
There was a problem hiding this comment.
Can we validate the parameters before passing it to the db manager? / Can we simply accept a job id from the request body?
| @@ -6,12 +6,20 @@ | |||
| * @return {Promise<void>} | |||
| */ | |||
| const routes = async (fastify, options) => { | |||
There was a problem hiding this comment.
I feel it might be better keeping the examples here. (Those can serve as heart beat / echo routes whenever we need check whether the server is online for debug purposes. )
Can we keep the examples and move the decompression routes into another file like query.js or decompression.js?
| fastify.get("/stats", async (req, resp) => { | ||
| const result = await fastify.dbManager.getStats(); | ||
| console.log(result); | ||
| resp.send(result); | ||
| }); |
There was a problem hiding this comment.
This was added as an example route in WIP #434 before the Alice / Bob examples were added. Now we have the better example routes, maybe we don't need this route any more.
Co-authored-by: Junhao Liao <[email protected]>
# Conflicts: # components/log-viewer-webui/server/package-lock.json # components/log-viewer-webui/server/package.json # components/log-viewer-webui/server/src/app.js # components/log-viewer-webui/server/src/main.js
| @@ -1,3 +1,8 @@ | |||
| CLIENT_DIR=../client/dist | |||
| IR_DATA_DIR=../../../build/clp-package/var/data/ir | |||
| LOG_VIEWER_DIR=../yscope-log-viewer/dist | |||
There was a problem hiding this comment.
@Henry8192 Kindly update here once your yscope-log-viewer integration PR is ready.
| @@ -798,6 +799,7 @@ def start_log_viewer_webui(instance_id: str, clp_config: CLPConfig, mounts: CLPD | |||
| "--log-driver", "local", | |||
| "-e", f"NODE_PATH={node_path}", | |||
| "-e", f"CLIENT_DIR={container_log_viewer_dir}/client/dist", | |||
There was a problem hiding this comment.
We should also add LOG_VIEWER_DIR once that is ready.
| await server.register(fastifyStatic, { | ||
| prefix: "/log-viewer", | ||
| root: logViewerDir, | ||
| decorateReply: false, |
There was a problem hiding this comment.
Needed for any second and after registration of fastifyStatic: https://github.com/fastify/fastify-static#disabling-reply-decorator
Co-authored-by: kirkrodrigues <[email protected]>
junhaoliao
force-pushed
the
log_viewer_server
branch
from
97fddf7 to
56791b5
Compare
junhaoliao
requested review from
kirkrodrigues
and removed request for
kirkrodrigues
junhaoliao
changed the title
…ion jobs and serving IR files; Don't copy unnecessary files when building component. (y-scope#458)
Description
This PR adds a basic server implementation for log-viewer-webui.
Validation performed
CLP_DB_PASSandCLP_DB_USERto.envfile.npm test.