-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
log-viewer-webui: Add server implementation for submitting IR extraction jobs and serving IR files; Don't copy unnecessary files when building component. #458
Merged
Merged
Changes from 18 commits
Commits
Show all changes
56 commits
Select commit
Hold shift + click to select a range
220aeb8
implement basic functions
wraymo b6dcb54
fix a bug
wraymo 77cd631
fix a bug
wraymo 8664a31
refactor a bit
wraymo b932901
add docstring
wraymo c13d39d
use 127.0.0.1 instead of localhost
wraymo f017d0b
remove example routes and test
wraymo 4729971
Apply suggestions from code review
kirkrodrigues 7859aba
Merge branch 'refs/heads/main' into log_viewer_server
junhaoliao 15b7459
Add `.env.local` for debug env var overrides.
junhaoliao 0c99ef1
Add .env.local to .gitignore for debug purposes.
junhaoliao f090aff
Remove .env.local from VCS.
junhaoliao 7a892dc
Add extract-IR job and polling, rework routes and DB interaction.
junhaoliao eda691c
Add IR_DATA_DIR and LOG_VIEWER_DIR into .env.
junhaoliao d3fe4a4
Add EOF.
junhaoliao 27b4d0d
Revert wrongly refactored docstring.
junhaoliao ea337cc
Rename `examples` to `example` in route URLs for consistency.
junhaoliao ea3210a
Update LOG_VIEWER_DIR default value in .env.
junhaoliao a9e9cc7
Merge branch 'refs/heads/main' into log_viewer_server
junhaoliao cf60f36
Specify `IR_DATA_DIR` when launching log-viewer-webui server in start…
junhaoliao f99a39e
Update package-lock.json.
junhaoliao a6a543f
Fix failed test cases.
junhaoliao be5a95f
Refactor server configuration to use settings.json.
junhaoliao 469bf3a
Strip out log-viewer-webui/client deps in clp-package; add settings.j…
junhaoliao ce6d76a
Clean up component `log-viewer-webui` in CLP package.
junhaoliao 0112dc1
Remove unused environment variables in main.js.
junhaoliao cf55e8c
Rearrange server initialization code in app.js to ensure fastifyStati…
junhaoliao 8baf2da
lint code.
junhaoliao fba76c3
Rename task "log-viewer-webui-clients" -> "log-viewer-webui-client".
junhaoliao 1af7e05
Add log-viewer-webui-client checksum to task `package`'s sources.
junhaoliao 8bb6af7
package: Refactor read_and_update_settings_json().
junhaoliao 4cb16ad
package: Add missing PORT envvar setting into start_log_viewer_webui …
junhaoliao e46f536
log-viewer-webui-server: replace dev dependency ``@babel/plugin-synta…
junhaoliao c6f3a87
Rename `irDataDir` -> `irFilesDir`.
junhaoliao 094f330
Remove extra line.
junhaoliao ac01b8d
Make DbManager methods `initMySql()` and `initMongo()` private.
junhaoliao ae9d86c
Store mysql connection pool instead of connection.
junhaoliao c125729
Make DbManager member irFilesCollection private.
junhaoliao 36a4f51
Rename `insertExtractIrJob` -> `submitAndWaitForExtractIrJob`.
junhaoliao 9b19d8b
Rename `getExtractedIrMetadata` -> `getExtractedIrFileMetadata`.
junhaoliao 0501a61
Rearrange parseEnvVars return object property order.
junhaoliao 299257f
Move NODE_ENV=test setting from app.test.js to package.json.
junhaoliao c02c9ee
Remove redundant line.
junhaoliao f0f05e2
Remove unnecessary export of parseEnvVars.
junhaoliao 06d4f84
Remove unnecessary `await`s on route registrations.
junhaoliao 89a7036
Use shorthand resp.send (return directly) in Fastify route handler.
junhaoliao 56791b5
Add "TODO: add tests for `query` routes." in app.test.js.
junhaoliao bcb3554
Refactor new read_and_update_settings_json method.
kirkrodrigues 4327c27
Refactor some comments and strings.
kirkrodrigues 1e1a85a
Clean-up previous PR.
kirkrodrigues 85c2954
Nit: Reorder user before pass.
kirkrodrigues 08cce9b
Mark method awaitJobCompletion as private.
junhaoliao 9339a3d
Remove redundant `await` in mysql pool assignment.
junhaoliao bd96c03
Add webui-log-viewer-server sources to task `package`'s `sources`.
junhaoliao 6a16fd8
Move var G_LOG_VIEWER_WEBUI_SRC_DIR definition lint-tasks.yml -> Task…
junhaoliao 10debf9
Update awaitJobCompletion docstring.
junhaoliao File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,8 @@ | ||
| CLIENT_DIR=../client/dist | ||
| IR_DATA_DIR=../../../build/clp-package/var/data/ir | ||
| LOG_VIEWER_DIR=../yscope-log-viewer/dist | ||
|
|
||
| HOST=localhost | ||
| PORT=3000 | ||
| CLP_DB_USER=clp-user | ||
| CLP_DB_PASS= | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,5 @@ | ||
| # Debug | ||
| .env.local | ||
|
|
||
| # Testing | ||
| /.tap |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Henry8192 Kindly update here once your
yscope-log-viewerintegration PR is ready.