Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
log-viewer-webui: Add server implementation for submitting IR extraction jobs and serving IR files; Don't copy unnecessary files when building component. #458
log-viewer-webui: Add server implementation for submitting IR extraction jobs and serving IR files; Don't copy unnecessary files when building component. #458
Changes from 7 commits
220aeb8
b6dcb54
77cd631
8664a31
b932901
c13d39d
f017d0b
4729971
7859aba
15b7459
0c99ef1
f090aff
7a892dc
eda691c
d3fe4a4
27b4d0d
ea337cc
ea3210a
a9e9cc7
cf60f36
f99a39e
a6a543f
be5a95f
469bf3a
ce6d76a
0112dc1
cf55e8c
8baf2da
fba76c3
1af7e05
8bb6af7
4cb16ad
e46f536
c6f3a87
094f330
ac01b8d
ae9d86c
c125729
36a4f51
9b19d8b
0501a61
299257f
c02c9ee
f0f05e2
06d4f84
89a7036
56791b5
bcb3554
4327c27
1e1a85a
85c2954
08cce9b
9339a3d
bd96c03
6a16fd8
10debf9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel it might be better keeping the examples here. (Those can serve as heart beat / echo routes whenever we need check whether the server is online for debug purposes. )
Can we keep the examples and move the decompression routes into another file like
query.js
ordecompression.js
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we validate the parameters before passing it to the db manager? / Can we simply accept a job id from the request body?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was added as an example route in WIP #434 before the Alice / Bob examples were added. Now we have the better example routes, maybe we don't need this route any more.