Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: Add support to compile clp::ffi component using MSVC. #341

Merged
merged 2 commits into from
Apr 1, 2024
Merged

core: Add support to compile clp::ffi component using MSVC. #341

merged 2 commits into from
Apr 1, 2024

Conversation

junhaoliao
Copy link
Member

@junhaoliao junhaoliao commented Mar 31, 2024 •
edited
Loading

References

Internally, it was found installing clp-ffi-py on Windows 11 gave errors. It was determined that the following needs to be added to support installation on Windows:

  1. MSVC equivalent Extension.extra_compile_args in setup.py.
  2. MSVC compatible bswap implementations.
  3. MSVC compatible argument types to function std::from_chars in <clp-repo-root>/components/core/src/string_utils.inc:convert_string_to_int.

Interdependent PR

y-scope/clp-ffi-py#56

Description

  1. This PR implements Requirement 2 & 3 from above.
  2. Requirement 1 are implemented in Add support for building the library on Windows using MSVC. clp-ffi-py#56 .

Validation performed

See y-scope/clp-ffi-py#56 .

@junhaoliao junhaoliao mentioned this pull request Mar 31, 2024
Merged
@junhaoliao junhaoliao changed the base branch from v0.5-prototype to main March 31, 2024 01:16
@junhaoliao junhaoliao mentioned this pull request Mar 31, 2024
Merged
@junhaoliao junhaoliao changed the title ffi-py: Add support for MSVC compilation. core: Add support for clp-ffi-py MSVC compilation. Mar 31, 2024
LinZhihao-723
LinZhihao-723 reviewed Mar 31, 2024
View reviewed changes
Copy link
Member

@LinZhihao-723 LinZhihao-723 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Trivial suggestions:

components/core/src/clp/string_utils/string_utils.hpp Outdated Show resolved Hide resolved
LinZhihao-723
LinZhihao-723 approved these changes Mar 31, 2024
View reviewed changes
Copy link
Member

@LinZhihao-723 LinZhihao-723 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Commit message: how about core: Add support to compile clp::ffi component using MSVC.?

kirkrodrigues
kirkrodrigues approved these changes Mar 31, 2024
View reviewed changes
Copy link
Member

@kirkrodrigues kirkrodrigues left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Zhihao's commit message.

@junhaoliao junhaoliao changed the title core: Add support for clp-ffi-py MSVC compilation. core: Add support to compile clp::ffi component using MSVC. Apr 1, 2024
@junhaoliao junhaoliao merged commit abf6826 into y-scope:main Apr 1, 2024
@junhaoliao junhaoliao deleted the clp-ffi-py-windows branch April 1, 2024 02:15
junhaoliao added a commit to junhaoliao/clp that referenced this pull request Apr 5, 2024
@junhaoliao
core: Add support to compile clp::ffi component using MSVC. (y-scope#341
0ab87e6 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinZhihao-723 LinZhihao-723 LinZhihao-723 approved these changes

@kirkrodrigues kirkrodrigues kirkrodrigues approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@junhaoliao @kirkrodrigues @LinZhihao-723