Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to the latest clp submodule commit. #55

Merged
merged 5 commits into from
Apr 15, 2024

Conversation

LinZhihao-723
Copy link
Member

@LinZhihao-723 LinZhihao-723 commented Mar 29, 2024

References

Description

This PR updates to the latest version of CLP. This will include PR y-scope/clp#341 to support Windows build.

Validation performed

  1. Tested locally to ensure the build flow worked and unit tests passed.
  2. GitHub workflow all passed.

@junhaoliao
Copy link
Member

Can we also pick the change from y-scope/clp#341 after it is merged?

(#56 needs that)

@LinZhihao-723
Copy link
Member Author

Can we also pick the change from y-scope/clp#341 after it is merged?

(#56 needs that)

Sure. I will update the submodule commit after CLP PR#341 merged.

@LinZhihao-723
Copy link
Member Author

Can we also pick the change from y-scope/clp#341 after it is merged?

(#56 needs that)

Done. Can u help review this PR?

junhaoliao
junhaoliao previously approved these changes Apr 5, 2024
Copy link
Member

@junhaoliao junhaoliao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I'm less familiar with the C/C++ coding styles at YScope, so it would still be good to have someone else to take a look.

junhaoliao
junhaoliao previously approved these changes Apr 11, 2024
@LinZhihao-723 LinZhihao-723 merged commit 5d09598 into y-scope:main Apr 15, 2024
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants