Add support for building the library on Windows using MSVC. #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junhaoliao
commented
Mar 31, 2024
.gitmodules
Outdated
| @@ -1,3 +1,4 @@ | |||
| [submodule "src/clp"] | |||
| path = src/clp | |||
| url = https://github.com/y-scope/clp.git | |||
| url = https://github.com/junhaoliao/clp.git | |||
There was a problem hiding this comment.
These shall not be merged
There was a problem hiding this comment.
The PR is merged with the latest CLP code: #55
There was a problem hiding this comment.
Some comments:
- Can u try to run the unit tests under the Windows dev environment?
- To properly build for Windows, we should also configure
cibuildwheelto build the library for different Python versions. We can delay this to the next PR if u want, but can u try if we can executecibuildwheellocally?
| @@ -37,6 +37,9 @@ | |||
| "src/clp_ffi_py/utils.cpp", | |||
| ], | |||
| extra_compile_args=[ | |||
| "/std:c++20", | |||
| "/O2," | |||
There was a problem hiding this comment.
O3 isn't a valid option for MSVC.
MSVC's /O2, which "sets a combination of optimizations that optimizes code for maximum speed", is roughly the equivalent of GCC's -O3.
There was a problem hiding this comment.
kk, good to know that, thx!
|
junhaoliao
changed the title
|
junhaoliao
commented
Apr 1, 2024
pyproject.toml
Outdated
| [tool.cibuildwheel.windows] | ||
| archs = ["AMD64"] | ||
| test-command = [ | ||
| "cd /d {package}\\tests", |
There was a problem hiding this comment.
The /d option must be specified or this error message gets reported: The system cannot find the path specified. That is because the project is synced into D:\ drive in GitHub Action workflows, which is a non-system (non-C:\) drive.
There was a problem hiding this comment.
Also the \ needs to be escaped. / might also work though.
There was a problem hiding this comment.
Can you test if "python -m unittest discover -s {package}/tests -fv" works on its own (rather than cd + unittest)?
README.md
Outdated
| @@ -19,7 +19,7 @@ python3 -m pip install --upgrade clp-ffi-py | |||
| Note: | |||
|
|
|||
| - Python 3.7 or higher is required. | |||
| - Only Linux and macOS are supported at present. | |||
| - Tested only on Linux, macOS and Windows. | |||
There was a problem hiding this comment.
Do we still need work "only", lol
There was a problem hiding this comment.
lol i was thinking about Solaris and FreeBSD when i wrote this, but yeah the word seems a bit unnecessary here
| @@ -37,6 +37,9 @@ | |||
| "src/clp_ffi_py/utils.cpp", | |||
| ], | |||
| extra_compile_args=[ | |||
| "/std:c++20", | |||
| "/O2," | |||
There was a problem hiding this comment.
kk, good to know that, thx!
LinZhihao-723
requested changes
Apr 15, 2024
.gitmodules
Outdated
| @@ -1,3 +1,4 @@ | |||
| [submodule "src/clp"] | |||
| path = src/clp | |||
| url = https://github.com/y-scope/clp.git | |||
| url = https://github.com/junhaoliao/clp.git | |||
There was a problem hiding this comment.
The PR is merged with the latest CLP code: #55
…install # Conflicts: # src/clp
LinZhihao-723
previously approved these changes
Apr 15, 2024
Co-authored-by: Lin Zhihao <[email protected]>
LinZhihao-723
approved these changes
Apr 15, 2024
junhaoliao
changed the title
|
Can I help release a new version on PyPI? I assume we also need to update clp-loglib-py, right? |
Sure, I will do it shortly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Internally, it was found installing
clp-ffi-pyon Windows 11 gave errors. It was determined that the following needs to be added to support installation on Windows:Extension.extra_compile_argsin setup.py.bswapimplementations.std::from_charsin<clp-repo-root>/components/core/src/string_utils.inc:convert_string_to_int.Interdependent PR
y-scope/clp#341
Description
cibuildwheelon Windows (AMD64) in GitHub Actions.Validation performed
Python 3.11.1 (tags/v3.11.1:a7a450f, Dec 6 2022, 19:58:39) [MSC v.1934 64 bit (AMD64)] on win32.cd e:\; git clone --recursive -b windows-install https://github.com/junhaoliao/clp-ffi-py.gitpip install E:\clp-ffi-py.