CI PR #1: Fix GitHub CI and 'tox' for local CI on Ubuntu 24.04
#143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- It has become impractical to use EOL versions like Python 3.6 in CI - It has become counterproductive to use pyre CI, disable it for now. - Move forward to run the unit tests with Python 3.11 Signed-off-by: Bernhard Kaindl <[email protected]>
bernhardkaindl
force-pushed
the
fix-github-ci-py38-removed
branch
from
2709be2 to
16ed521
Compare
Pull Request Test Coverage Report for Build 11857456745Details
💛 - Coveralls |
bernhardkaindl
changed the title
CI PR #1: Fix GitHub CI and 'tox' for local CI on Ubuntu 24.04
This was referenced Nov 15, 2024
GeraldEV
reviewed
Nov 20, 2024
| @@ -8,10 +8,11 @@ | |||
| # These are the most of the needed pytest plugins, unfortunately this list does | |||
| # not support ;python_version<=3.0 or ;python_version>3.0. Therefore, it can | |||
| # only list plugins available for all tested python versions (2.7, 3.6 ... 3.11): | |||
| # pytest-localftpserver is also used, but its installation is not checked | |||
| # to to its installation not being detected on Ubuntu 24.04: | |||
There was a problem hiding this comment.
due to its installation...
GeraldEV
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Topic: Fix GitHub CI
Contents:
pyright) to use pyre CI, disable it for now.A follow-up PR has been created that includes this commit and compensates for the minimal loss in code coverage:
CI PR #2:Fix GitHub CI and add checks to compensate for code coverage #144Note:
If you have review comments, I'd like to apply them using the last PR in this series!