Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI PR #10: pre-commit/pytype: Use Python 3.11, create missing output dirs #152

Open
wants to merge 35 commits into
base: master
Choose a base branch
from

Conversation

bernhardkaindl
Copy link
Collaborator

@bernhardkaindl bernhardkaindl commented Nov 16, 2024

Topic: Fix GitHub CI

In this PR:

  • pre-commit/pytype: Use Python 3.11 and create missing output directories

Contents:

  • Commit 1 from CI PR #1: Fix GitHub CI and 'tox' for local CI on Ubuntu 24.04 #143: (please review)

    • It has become impractical to use EOL versions like Python 2.7 & 3.6 in CI
    • It has become counterproductive to use pyre CI, disable it for now.
    • Move forward to run the unit tests with Python 3.11
  • Commits 2,3 from CI PR #2: Fix GitHub CI and add checks to compensate for code coverage #144: (please review)

    • Compensate the code coverage by adding new checks
    • Fix two spelling typos in the comments
  • Commit 4 from CI PR #3: Fix the 1st half of the pyright warnings in the unit tests #145: (please review)

    • Fix the 1st half of the pyright warnings in the unit tests
  • Commit 5, 6, 7 and 8 from CI PR #4: Fix pylint and 2nd half of the pyright warnings #146: (please review)

    • Fix pylint and 2nd half of the pyright warnings
    • pyright: Bump Python version to check to 3.11
    • pyright: Fix ErrorHandler taking Response | None
    • pyright: Skip warning on renamed arg: FTPAccessor.access(name->path)
  • Commits 9-13 from CI PR #5: Complete the transition from pyre to pyright #147: (please review)

    • tox.ini: Complete the transition from pyre to pyright
    • pre-commit: Remove the remaining call to pyre in pre-commit
    • docs: Complete the transition from pyre to pyright
    • tox.ini/pyright: Fail tox if pyright fails (enforce check)
    • pyre: Finally, remove obsolete pyre-error suppressions
  • Commit 14-18 from CI PR #6: GitHub CI/tox: Update CI to use Python 3.11, 3.12 and 3.13 #148: (please review)

    • CI PR #6: GitHub CI/tox: Update CI to use Python 3.11, 3.12 and 3.13
    • Fix test_bootloader.py/pylint: assertRegexpMatches renamed to assertRegex
    • CONTRIBUTING.md: Add venv setup and using pipx
    • tests/test_logger.py: Use pyfakefs: don't create a file in the host
    • .github/workflows/main.yml: Cleanup obsolete code for Python 2.7/3.8
  • Commit 19-22 from CI PR #7: docs: Fix Markdown format for proper markdown linting #149: (please review)

    • CONTRIBUTING.md: Fix Markdown format for linting
    • README.md: Fix Markdown format for linting and update it
    • README-Unicode.md: Fix Markdown format for linting and update it
    • .pre-commit-config.yaml: Replace mdformat check with markdownlint-cli
  • Commits 23-27 from CI PR #8: Fix pre-commit checks #150: (please review)

    • pre-commit config: Fix check: python-check-blanket-type-ignore
    • .pre-commit-config.yaml: Fix pre-commit config: pytest, mypy & pylint
    • .github/workflows/main.yml: Add CI job for running pre-commit
    • pre-commit: Fix warning about deprecated hook config: Update hooks
    • .pre-commit-config.yaml: Fix pre-commit configuration for pytype
  • Commits 28-34 from CI PR #9: docs: Fix typos and spelling errors, add cspell #151: (please review)

    • README.md: Fix typos and spelling errors
    • CONTRIBUTING.md: Fix typos and spelling errors
    • README-Unicode.md: Fix typos and spelling errors
    • Fix typos in code comments, simplify them
    • pylint,pytype wrappers: Fix spell check on short variable names
    • unit tests: Fix spell check for the unit tests
    • .pre-commit-config.yaml: Add the CSpell spell checker
  • Commit 35 from this PR:

    • pre-commit/pytype: Use Python 3.11 and create missing output directories

Note:
This is the last PR in this series.
If have review comments, I'd like to apply them in this PR.

- It has become impractical to use EOL versions like Python 3.6 in CI
- It has become counterproductive to use pyre CI, disable it for now.
- Move forward to run the unit tests with Python 3.11

Signed-off-by: Bernhard Kaindl <[email protected]>
@coveralls
Copy link

coveralls commented Nov 16, 2024

Pull Request Test Coverage Report for Build 11867486001

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 12 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.009%) to 83.661%

Files with Coverage Reduction New Missed Lines %
xcp/accessor.py 1 89.1%
xcp/xmlunwrap.py 2 92.31%
xcp/cpiofile.py 3 75.26%
xcp/compat.py 6 78.57%
Totals Coverage Status
Change from base Build 9109272969: -0.009%
Covered Lines: 2806
Relevant Lines: 3354

💛 - Coveralls

@bernhardkaindl bernhardkaindl force-pushed the pytype-use-3.11-make-outdir branch 4 times, most recently from ae346b6 to f6e4f58 Compare November 16, 2024 05:13
@bernhardkaindl bernhardkaindl force-pushed the pytype-use-3.11-make-outdir branch from f6e4f58 to 07fbe44 Compare November 16, 2024 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants