-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI PR #10
: pre-commit
/pytype
: Use Python 3.11, create missing output dirs
#152
Open
bernhardkaindl
wants to merge
35
commits into
master
Choose a base branch
from
pytype-use-3.11-make-outdir
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- It has become impractical to use EOL versions like Python 3.6 in CI - It has become counterproductive to use pyre CI, disable it for now. - Move forward to run the unit tests with Python 3.11 Signed-off-by: Bernhard Kaindl <[email protected]>
Signed-off-by: Bernhard Kaindl <[email protected]>
Signed-off-by: Bernhard Kaindl <[email protected]>
Signed-off-by: Bernhard Kaindl <[email protected]>
Signed-off-by: Bernhard Kaindl <[email protected]>
Signed-off-by: Bernhard Kaindl <[email protected]>
Signed-off-by: Bernhard Kaindl <[email protected]>
Signed-off-by: Bernhard Kaindl <[email protected]>
Signed-off-by: Bernhard Kaindl <[email protected]>
Signed-off-by: Bernhard Kaindl <[email protected]>
Signed-off-by: Bernhard Kaindl <[email protected]>
Signed-off-by: Bernhard Kaindl <[email protected]>
Signed-off-by: Bernhard Kaindl <[email protected]>
Signed-off-by: Bernhard Kaindl <[email protected]>
…egex Signed-off-by: Bernhard Kaindl <[email protected]>
Signed-off-by: Bernhard Kaindl <[email protected]>
Signed-off-by: Bernhard Kaindl <[email protected]>
Signed-off-by: Bernhard Kaindl <[email protected]>
Signed-off-by: Bernhard Kaindl <[email protected]>
Signed-off-by: Bernhard Kaindl <[email protected]>
Signed-off-by: Bernhard Kaindl <[email protected]>
Signed-off-by: Bernhard Kaindl <[email protected]>
Signed-off-by: Bernhard Kaindl <[email protected]>
Signed-off-by: Bernhard Kaindl <[email protected]>
Signed-off-by: Bernhard Kaindl <[email protected]>
Signed-off-by: Bernhard Kaindl <[email protected]>
Signed-off-by: Bernhard Kaindl <[email protected]>
Signed-off-by: Bernhard Kaindl <[email protected]>
Signed-off-by: Bernhard Kaindl <[email protected]>
Signed-off-by: Bernhard Kaindl <[email protected]>
Signed-off-by: Bernhard Kaindl <[email protected]>
Signed-off-by: Bernhard Kaindl <[email protected]>
Signed-off-by: Bernhard Kaindl <[email protected]>
Signed-off-by: Bernhard Kaindl <[email protected]>
Pull Request Test Coverage Report for Build 11867486001Details
💛 - Coveralls |
bernhardkaindl
force-pushed
the
pytype-use-3.11-make-outdir
branch
4 times, most recently
from
November 16, 2024 05:13
ae346b6
to
f6e4f58
Compare
Signed-off-by: Bernhard Kaindl <[email protected]>
bernhardkaindl
force-pushed
the
pytype-use-3.11-make-outdir
branch
from
November 16, 2024 05:15
f6e4f58
to
07fbe44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Topic: Fix GitHub CI
In this PR:
pre-commit
/pytype
: Use Python 3.11 and create missing output directoriesContents:
Commit 1 from
CI PR #1:
Fix GitHub CI and 'tox' for local CI on Ubuntu 24.04 #143: (please review)Commits 2,3 from
CI PR #2:
Fix GitHub CI and add checks to compensate for code coverage #144: (please review)Commit 4 from
CI PR #3:
Fix the 1st half of the pyright warnings in the unit tests #145: (please review)pyright
warnings in the unit testsCommit 5, 6, 7 and 8 from
CI PR #4:
Fix pylint and 2nd half of the pyright warnings #146: (please review)pylint
and 2nd half of thepyright
warningspyright
: Bump Python version to check to 3.11pyright
: Fix ErrorHandler takingResponse | None
pyright
: Skip warning on renamed arg:FTPAccessor.access(name->path)
Commits 9-13 from
CI PR #5:
Complete the transition frompyre
topyright
#147: (please review)tox.ini
: Complete the transition frompyre
topyright
pre-commit
: Remove the remaining call topyre
inpre-commit
docs
: Complete the transition frompyre
topyright
tox.ini
/pyright
: Fail tox ifpyright
fails (enforce check)pyre
: Finally, remove obsoletepyre-error
suppressionsCommit 14-18 from
CI PR #6:
GitHub CI/tox
: Update CI to use Python3.11
,3.12
and3.13
#148: (please review)CI PR #6:
GitHub CI/tox
: Update CI to use Python3.11
,3.12
and3.13
test_bootloader.py
/pylint
:assertRegexpMatches
renamed toassertRegex
CONTRIBUTING.md
: Addvenv
setup and usingpipx
tests/test_logger.py
: Usepyfakefs
: don't create a file in the host.github/workflows/main.yml
: Cleanup obsolete code for Python 2.7/3.8Commit 19-22 from
CI PR #7:
docs: Fix Markdown format for proper markdown linting #149: (please review)CONTRIBUTING.md
: Fix Markdown format for lintingREADME.md
: Fix Markdown format for linting and update itREADME-Unicode.md
: Fix Markdown format for linting and update it.pre-commit-config.yaml
: Replace mdformat check with markdownlint-cliCommits 23-27 from
CI PR #8:
Fix pre-commit checks #150: (please review)pre-commit
config: Fix check: python-check-blanket-type-ignore.pre-commit-config.yaml
: Fix pre-commit config: pytest, mypy & pylint.github/workflows/main.yml
: Add CI job for running pre-commitpre-commit
: Fix warning about deprecated hook config: Update hooks.pre-commit-config.yaml
: Fix pre-commit configuration for pytypeCommits 28-34 from
CI PR #9
: docs: Fix typos and spelling errors, add cspell #151: (please review)README.md
: Fix typos and spelling errorsCONTRIBUTING.md
: Fix typos and spelling errorsREADME-Unicode.md
: Fix typos and spelling errorspylint
,pytype
wrappers: Fix spell check on short variable names.pre-commit-config.yaml
: Add the CSpell spell checkerCommit 35 from this PR:
pre-commit
/pytype
: Use Python 3.11 and create missing output directoriesNote:
This is the last PR in this series.
If have review comments, I'd like to apply them in this PR.