Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI PR #4: Fix pylint and 2nd half of the pyright warnings #146

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

bernhardkaindl
Copy link
Collaborator

@bernhardkaindl bernhardkaindl commented Nov 15, 2024

Topic: Fix GitHub CI

  • GitHub dropped support for EOL Python versions in GitHub CI

Contents:

Note:
If you have review comments, I'd like to apply them using the last PR in this series!

- It has become impractical to use EOL versions like Python 3.6 in CI
- It has become counterproductive to use pyre CI, disable it for now.
- Move forward to run the unit tests with Python 3.11

Signed-off-by: Bernhard Kaindl <[email protected]>
@bernhardkaindl bernhardkaindl changed the title [CI fixes PR #4] Fix pylint and 2nd half of the pyright warnings CI PR #4: Fix pylint and 2nd half of the pyright warnings Nov 15, 2024
@coveralls
Copy link

coveralls commented Nov 15, 2024

Pull Request Test Coverage Report for Build 11859913232

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 12 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.009%) to 83.661%

Files with Coverage Reduction New Missed Lines %
xcp/accessor.py 1 89.1%
xcp/xmlunwrap.py 2 92.31%
xcp/cpiofile.py 3 75.26%
xcp/compat.py 6 78.57%
Totals Coverage Status
Change from base Build 9109272969: -0.009%
Covered Lines: 2806
Relevant Lines: 3354

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants