-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI PR #4:
Fix pylint and 2nd half of the pyright warnings
#146
Open
bernhardkaindl
wants to merge
8
commits into
master
Choose a base branch
from
fix-github-ci-pylint-and-2nd-pyright-warnings
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
CI PR #4:
Fix pylint and 2nd half of the pyright warnings
#146
bernhardkaindl
wants to merge
8
commits into
master
from
fix-github-ci-pylint-and-2nd-pyright-warnings
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- It has become impractical to use EOL versions like Python 3.6 in CI - It has become counterproductive to use pyre CI, disable it for now. - Move forward to run the unit tests with Python 3.11 Signed-off-by: Bernhard Kaindl <[email protected]>
Signed-off-by: Bernhard Kaindl <[email protected]>
Signed-off-by: Bernhard Kaindl <[email protected]>
Signed-off-by: Bernhard Kaindl <[email protected]>
Signed-off-by: Bernhard Kaindl <[email protected]>
bernhardkaindl
changed the title
[CI fixes PR #4] Fix pylint and 2nd half of the pyright warnings
Nov 15, 2024
CI PR #4:
Fix pylint and 2nd half of the pyright warnings
Pull Request Test Coverage Report for Build 11859913232Details
💛 - Coveralls |
Signed-off-by: Bernhard Kaindl <[email protected]>
Signed-off-by: Bernhard Kaindl <[email protected]>
Signed-off-by: Bernhard Kaindl <[email protected]>
This was referenced Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Topic: Fix GitHub CI
Contents:
CI PR #1:
Fix GitHub CI and 'tox' for local CI on Ubuntu 24.04 #143:CI PR #2:
Fix GitHub CI and add checks to compensate for code coverage #144:CI PR #3:
Fix the 1st half of the pyright warnings in the unit tests #145:pyright
warnings in the unit testspylint
and 2nd half of thepyright
warningspyright
: Bump Python version to check to 3.11pyright
: Fix ErrorHandler takingResponse | None
pyright
: Skip warning on renamed arg:FTPAccessor.access(name->path)
Note:
If you have review comments, I'd like to apply them using the last PR in this series!