Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove all skipLibCheck #4910

Merged
merged 1 commit into from
Dec 6, 2023
Merged

chore: remove all skipLibCheck #4910

merged 1 commit into from
Dec 6, 2023

Conversation

xiaoxiangmoe
Copy link
Contributor

Summary

This issue is part of #4640

Test Plan

Require Documentation?

  • No
  • Yes, the corresponding rspack-website PR is __

@xiaoxiangmoe xiaoxiangmoe requested review from a team, LingyuCoder and h-a-n-a December 5, 2023 14:36
@hardfist
Copy link
Contributor

hardfist commented Dec 5, 2023

I'm not sure we have type check now, since we migrate from ts-jest to swc-jest

@xiaoxiangmoe
Copy link
Contributor Author

@hardfist This is type check for build，you can see package.json's build script

@hardfist hardfist enabled auto-merge December 6, 2023 06:16
@hardfist hardfist added this pull request to the merge queue Dec 6, 2023
Merged via the queue into web-infra-dev:main with commit 44bcc00 Dec 6, 2023
16 checks passed
ahabhgk pushed a commit that referenced this pull request Jan 2, 2024
@xiaoxiangmoe @ahabhgk
chore: remove all skipLibCheck (#4910)
38c8801
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hardfist hardfist hardfist approved these changes

@LingyuCoder LingyuCoder Awaiting requested review from LingyuCoder

@h-a-n-a h-a-n-a Awaiting requested review from h-a-n-a

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xiaoxiangmoe @hardfist